Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new operator for matching strings against regular expressions #534

Merged
merged 3 commits into from
Aug 9, 2024
Merged

feat: new operator for matching strings against regular expressions #534

merged 3 commits into from
Aug 9, 2024

Conversation

Taepper
Copy link
Collaborator

@Taepper Taepper commented Aug 5, 2024

resolves #517

Summary

Introduce a new Filter that filters String fields with regular expressions. Google's RE2 library is used for matching each string value against the user-provided regular expression

PR Checklist

  • All necessary documentation has been adapted or there is an issue to do so.
  • The implemented feature is covered by an appropriate test.

@Taepper Taepper force-pushed the regex-search branch 4 times, most recently from 89321dd to ae5cac4 Compare August 7, 2024 09:08
@Taepper Taepper marked this pull request as ready for review August 7, 2024 09:13
@Taepper Taepper requested a review from pflanze August 7, 2024 09:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

This is a preview of the changelog of the next release:

0.2.14 (2024-08-07)

Features

  • new operator for matching strings against regular expressions (d6c2a98)

Bug Fixes

  • typo in the error message if a column is not found (b3147d5)

pflanze
pflanze requested changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@pflanze pflanze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the mentioned points.

endToEndTests/test/queries/stringSearch_basic_regex.json Outdated Show resolved Hide resolved
include/silo/query_engine/filter_expressions/string_search.h Outdated Show resolved Hide resolved
include/silo/query_engine/filter_expressions/string_search.h Outdated Show resolved Hide resolved
src/silo/query_engine/filter_expressions/expression.cpp Outdated Show resolved Hide resolved
src/silo/query_engine/filter_expressions/string_search.cpp Show resolved Hide resolved
pflanze
pflanze approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@pflanze pflanze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be documented later in whatever place user docs go.

@Taepper Taepper merged commit 67029a4 into main Aug 9, 2024
10 checks passed
@Taepper Taepper deleted the regex-search branch August 9, 2024 06:45
@fengelniederhammer fengelniederhammer mentioned this pull request Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pflanze pflanze pflanze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

String search with regular expressions
2 participants
@Taepper @pflanze