temporary commandlinesplit alex's branch. For github diff and better reading for team #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taepper
changed the title
For now it's better to continue to use the existing separate CI commands for testing, as there is some mess in how dependencies are currently tracked (this could be improved) and thus may be flakey. TODO: docs
Allowing use like `DEBUGGER=gdbrun make runapi-tsv` (for gdbrun see https://github.com/pflanze/chj-bin/blob/master/gdbrun).
BREAKING CHANGE: config files need to be changed. Refs: #524
- Add struct `QueryOptions` and add it as field to `RuntimeConfig`. - The bulk of `RuntimeConfig` becomes `ApiOptions`; `ApiOptions` was already introduced in commit c8cf88e ("refactor: enable YAMLFiles as ConfigSources to have substructs"). - add `overwrite` methods to ApiOptions and QueryOptions (and RuntimeConfig as a delegate) Refs: #524
This replaces the previous way for choosing execution mode via `--api`
option with two different program names, but to save on linker time
and disk space build a multi-call binary that is made available under
the two new names via symlinks.
- Remove `--api` option.
- Add `enum class ExecutionMode { PREPROCESSING, API }`, and
`executionModeFromPath` function that detects the case from the
program path.
- Add a new class `SiloApp` that imlements `displayHelp` for shared
help text.
- Implement separate `SiloPreprocessor` and `SiloServer` classes that
inherit/implement `Poco::Util::ServerApplication` via `SiloApp`
instead of just the previous `SiloServer`.
- Do not catch exceptions in the program `main` procedure if
`DEBUG_EXCEPTION` is set (one step towards being able to use the
debugger to look at exception contexts within http handlers, Poco
itself still prevents it).
- Avoid duplication of code for adding of the database config option
via new `addDatabaseConfigOption(..)` function.
- Generate a single binary now called `silo` instead of `siloApi`, but
additionally create `siloServer` and `siloPreprocessor` symlinks to
it via cmake in `CMakeLists.txt`.
- Update `Dockerfile`.
- Update the files in `.run/`.
Closes #524
…processor' programs Refs: #524
That seems like a crude approach, but it gets the job done. Refs: #524
config|config_reader => config_source, because the type is called config source. Refs: #524
…se strings XXX sigh. so is it wrong now weil now zu VIEL unix making drin isch gell ?
Because it covers preprocessing, too, and it's more natural to see "main" in the file name to know that this is what defines the `main` function. Refs: #524
…_config_file` * replaces the `Option` constants in silo::config * replaces the manually written fields in the struct * replaces the implementation of `overwrite` * XXX and more to come hat ZU VIEL: * removal of DATABASE_CONFIG_OPTION mit ALT "databaseConfig" string gosh, muss doch bei " add field for database config to preprocessingconfig gl" sein. but eh alles zusamm ? chm jenes hierher holen.
…dentifier NO HAS_NO_DEFAULT
Issue #524 Closes #444, #570, #594. Todo: - preprocessing_config (adapt macros) - main: first argument logic, and integrate into original code. - boost parses -1 as unsigned integers wrongly, silently - boost does not parse "true" as bool, just "1" (bad for YAML?!) - process SILO_PANIC as normal option, too? - check 'XX' comments
Taepper
force-pushed
the
at_commandlinesplit
branch
from
cb6c782
to
ce0c287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR Checklist