Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faddeeva improvements #31

Merged
merged 11 commits into from
Jun 12, 2024
Merged

faddeeva improvements #31

merged 11 commits into from
Jun 12, 2024

Conversation

kleinhenz
Copy link
Collaborator

  • avoid unnecessary overflows in float32 by rearranging exponential factors in w_mm and w_mt
  • when there is a true overflow due to large negative imaginary part overflow to inf instead of nan to match scipy behavior

@kleinhenz kleinhenz requested a review from 0x00b1 June 10, 2024 16:12
@kleinhenz kleinhenz marked this pull request as ready for review June 10, 2024 16:19
@kleinhenz
Copy link
Collaborator Author

ok I think I've addressed everything

@0x00b1 0x00b1 merged commit 9d2a54b into main Jun 12, 2024
6 of 11 checks passed
@0x00b1 0x00b1 deleted the faddeeva branch June 12, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x00b1 0x00b1 0x00b1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kleinhenz @0x00b1