Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive checklist format update? #40

Open
ddsjoberg opened this issue Sep 9, 2024 · 2 comments
Open

Interactive checklist format update? #40

ddsjoberg opened this issue Sep 9, 2024 · 2 comments
Labels
scope-enhancement enhancing existing features theme-cli command line output and communication

Comments

@ddsjoberg
Copy link

First, I love this work. I am using it now and thinking of ways to use it more. Thank you!

I find myself watching the interactive updates (they are so cute) during the rev dep checks. Last time I was watching the progress, I had a thought about a potential improvement to the format the information is displayed. Many reverse dependencies are packages totally out of our control and I am not really concerned whether or not there is an error/warning/note in the checks on any single version. Rather, I want to see whether there are new error/warning/notes using the dev version for the check. Perhaps a counter that had one row per rev dep and reported on new error/warning/notes would be more informative?

image
@dgkf-roche dgkf-roche added theme-cli command line output and communication scope-enhancement enhancing existing features labels Sep 11, 2024
@dgkf-roche
Copy link
Collaborator

dgkf-roche commented Sep 11, 2024

This would be amazing, and I think it should be pretty manageable. Maybe we could do something like this:

                              │ S │ OK  N  W  E │
─ gtsummary ──────────────────┼───┼─────────────┼──────────────────────────────────────────
              +cards (v0.2.2) │ ✓ │ 47  0  0  0 │ 2.5s
     +cards (dev v0.2.2.9000) │ W │ -2 +1 +1  0 │ 2.5s
─ cardx ──────────────────────┼───┼─────────────┼──────────────────────────────────────────
              +cards (v0.2.2) │ ✓ │ 40  0  0  0 │ 2.5s
     +cards (dev v0.2.2.9000) │ ◓ │ 22  0  1  0 │ 3.6s checking if there is a namespace ...

When in progress, the task is reporting the total of each category, and once it finishes it reports the diff. I like this style because it groups the information, but it's still a bit hard to scan visually to see which packages are problematic. We could maybe find a way to highlight each group with an indicator after both the release and dev jobs have finished.

@ddsjoberg
Copy link
Author

ooooo, this looks beautiful! I love the plus/minus notation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-enhancement enhancing existing features theme-cli command line output and communication
Projects
None yet
Development

No branches or pull requests

2 participants