Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development revdep check #47

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

maksymiuks
Copy link
Collaborator

No description provided.

@maksymiuks maksymiuks linked an issue Nov 7, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (e0edbe8) to head (2a061fc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   89.66%   89.87%   +0.21%     
==========================================
  Files          21       21              
  Lines        1374     1393      +19     
==========================================
+ Hits         1232     1252      +20     
+ Misses        142      141       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dgkf-roche dgkf-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Only further thought is that it would be nice if we could report all the packages that would fall into this category at once instead of just the first that gets attempted to avoid having users repeatedly remove packages from their library and re-starting.

I think that would add a lot more error management - not sure it's worth the extra effort.

@maksymiuks
Copy link
Collaborator Author

Comments addressed online, merging :)

@maksymiuks maksymiuks merged commit 00f6a2b into main Nov 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethink development revdep checks
2 participants