Add macros for components #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonschumacher
force-pushed
the
JS/add-components
branch
from
1b385f2
to
4d550cb
Compare
|
Thank you very much for this PR @jonschumacher, and apologies for taking so long to review it. I'm not familiar with components, although from what I've seen in the Swagger docs and in your code this would be very useful to avoid code repetition. I see you've added a section to the README showing how to declare a component. Could you please also show how to reference said component from somewhere else? Thank you |
|
No worries, we all have much on the table. b639861 adds a usage example to the README. |
|
Thank you! Merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds macros for the component section of an OpenAPI file. I also added a scheme for OpenAPI 3.1 to allow for referencing e.g. parameters.
Closes #7