Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add reencryption service #50

Merged
merged 8 commits into from
Apr 26, 2024
Merged

add reencryption service #50

merged 8 commits into from
Apr 26, 2024

Conversation

MalinAhlberg
Copy link
Contributor

@MalinAhlberg MalinAhlberg commented Apr 22, 2024 •
edited
Loading

This PR closes #49 .

  • adds the re-encryption service to the main docker file
  • fixes the image name of auth and its configs

@MalinAhlberg MalinAhlberg force-pushed the fix/add-reencryption-service branch from 106c479 to 1934726 Compare April 22, 2024 13:56
@MalinAhlberg MalinAhlberg marked this pull request as ready for review April 23, 2024 11:39
@MalinAhlberg
Copy link
Contributor Author

Issue #51 added to improve the documentation, so that testing the setup will be easier.

jbygdell
jbygdell reviewed Apr 23, 2024
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@MalinAhlberg @jbygdell
remove unused volume
d3020d3 
Co-authored-by: Joakim Bygdell <[email protected]>
jbygdell
jbygdell reviewed Apr 23, 2024
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@MalinAhlberg MalinAhlberg requested a review from jbygdell April 25, 2024 07:12
pahatz
pahatz approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@pahatz pahatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MalinAhlberg MalinAhlberg merged commit 96f8f77 into main Apr 26, 2024
1 check passed
@MalinAhlberg MalinAhlberg deleted the fix/add-reencryption-service branch April 26, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjiangshu nanjiangshu nanjiangshu left review comments

@aaperis aaperis aaperis approved these changes

@jbygdell jbygdell jbygdell approved these changes

@pahatz pahatz pahatz approved these changes

@kusalananda kusalananda Awaiting requested review from kusalananda

@kostas-kou kostas-kou Awaiting requested review from kostas-kou

@dbampalikis dbampalikis Awaiting requested review from dbampalikis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update main docker compose with re-encrypt service
5 participants
@MalinAhlberg @nanjiangshu @pahatz @jbygdell @aaperis