Skip to content

Commit

Permalink
feat: allow test artifact upload to be optional
Browse files Browse the repository at this point in the history
require it as an input
  • Loading branch information
geonetci committed Oct 29, 2024
1 parent b10b9ae commit 07ec667
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .github/workflows/reusable-go-container-apps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ on:
required: false
description: |
shell commands to setup the test environment
testUpload:
type: boolean
required: true
default: true
golangciSetup:
type: string
required: false
Expand Down Expand Up @@ -146,6 +150,7 @@ jobs:
with:
setup: ${{ inputs.testSetup }}
extraArgs: ${{ inputs.goTestExtraArgs }}
upload: ${{ inputs.testUpload }}
go-vet:
if: ${{ contains(fromJSON('["workflow_call", "workflow_dispatch", "push", "pull_request"]'), github.event_name) && startsWith(github.repository, 'GeoNet/') != false }}
uses: GeoNet/Actions/.github/workflows/reusable-go-vet.yml@main
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-go-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:
extra args to pass `go test`
upload:
required: false
default: false
default: true
type: boolean
description: |
set to true to push test coverage as an artifact
Expand Down

0 comments on commit 07ec667

Please sign in to comment.