Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy 1 #240

Merged
merged 1 commit into from
Aug 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ if [ $# -eq 0 ]; then
exit 1
fi

# code will be compiled in this container
BUILDER_IMAGE='quay.io/geonet/golang:1.16-alpine'
RUNNER_IMAGE='quay.io/geonet/go-scratch:latest'

VERSION='git-'$(git rev-parse --short HEAD)
ACCOUNT=$(aws sts get-caller-identity --output text --query 'Account')

Expand All @@ -39,8 +35,6 @@ for i in "$@"; do

docker build \
--build-arg=BUILD="$i" \
--build-arg=RUNNER_IMAGE="$RUNNER_IMAGE" \
--build-arg=BUILDER_IMAGE="$BUILDER_IMAGE" \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: should the above lines also be removed?

# code will be compiled in this container
BUILDER_IMAGE='quay.io/geonet/golang:1.16-alpine'
RUNNER_IMAGE='quay.io/geonet/go-scratch:latest'

--build-arg=GIT_COMMIT_SHA="$VERSION" \
--build-arg=ASSET_DIR="./cmd/$i/assets" \
-t "${ACCOUNT}.dkr.ecr.ap-southeast-2.amazonaws.com/${i}:$VERSION" \
Expand Down
2 changes: 2 additions & 0 deletions cmd/fdsn-quake-consumer/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ func (n *notification) Process(msg []byte) error {
if err := e.save(); err != nil {
return fmt.Errorf("error saving SC3ML %s %s: %w", v.S3.Bucket.Name, v.S3.Object.Key, err)
}

log.Println("saved", e.PublicID)
sue-h-gns marked this conversation as resolved.
Show resolved Hide resolved
}

return nil
Expand Down