Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support runtime change of samplerate #91

Open
fyrebreak opened this issue Nov 9, 2024 · 13 comments
Open

Support runtime change of samplerate #91

fyrebreak opened this issue Nov 9, 2024 · 13 comments
Labels

Comments

@fyrebreak
Copy link

My system is as follows:

Device name Panopticon
Processor AMD Ryzen 7 5800H with Radeon Graphics 3.20 GHz
Installed RAM 32.0 GB (27.9 GB usable)
System type 64-bit operating system, x64-based processor
Edition Windows 11 Home
Reaper v7.25

Project details: 48kHz sample rate

Bug present on VST3 and LV2 builds on Geonkick 3.5.0

My current project uses about 6 instances of Geonkick for different samples. Bug occurs when I choose to render my project, and the drum preset I created below:

image

gets replaced with the initialized preset of the plugin:

image

This occurs even when freezing my tracks, which also involves rendering, and makes the plugin unusable for me.

@fyrebreak
Copy link
Author

Have attempted to abridge the plugin as shown below, but same bug is still present. Lost presets again.
image

@fyrebreak
Copy link
Author

Upon rendering, the plugin also appears to not be able to load its abridged GUI, after the bug initializes its preset to default.

image

@iurienistor
Copy link
Member

iurienistor commented Nov 10, 2024

Hi! I've done these steps:

  1. Add two Geonkick MIDI tracks. Edit the wavefrom.
  2. Render to file.
  3. Open again the UI of Geonkick plugins. The states are saved, are not reset.

I am not a reaper user but I hope I have done the steps correctly to reproduce.

On Windows 11, latest version of reaper 7.27

@iurienistor
Copy link
Member

iurienistor commented Nov 10, 2024

@fyrebreak I have attached the video of my test.

render.mp4

@iurienistor
Copy link
Member

@fyrebreak
Here freeze/unfreeze

freezeunfreeze.mp4

@fyrebreak
Copy link
Author

Thanks for trying out the test cases. I'm trying to send a video back as well, but in the meantime here's some things that will hopefully trigger the bug?

  1. Rendering an MP3 file from the render window
  2. Saving a default preset of the plugin on the Reaper dialog window, closing and opening Reaper, and then trying to render an MP3 file again
  3. Changing your sample rate of the project to 48kHz instead of 41kHz

@iurienistor
Copy link
Member

@fyrebreak Ok, I'll try this too. As you said your preset contains a sample. Is the preset you created loaded ok when you save and load it?

@fyrebreak
Copy link
Author

Thanks, here's my test.
https://github.com/user-attachments/assets/7c3aafa5-10f0-42f0-afaf-33e2148db44c

My preset is okay initially, I could check on the sample if you want to make sure that it's initialised properly.

@fyrebreak
Copy link
Author

2024-11-10.18-50-17.mp4

I believed I nailed something down. I set my project to 44.1kHz in sample rate and it works. Let me know if you're able to replicate the bug at 48kHz as well, or if you'd like me to test other sample rates.

@iurienistor
Copy link
Member

Updated test. I cannot reproduce. Maybe I am dong something wrong.
https://github.com/user-attachments/assets/447ec380-872c-4c7e-96b5-a1dcced6d851

@gwee007
Copy link

gwee007 commented Nov 10, 2024

2024-11-10.19-12-57.mp4

Try the following?

@iurienistor
Copy link
Member

iurienistor commented Nov 10, 2024

@gwee007 @flewkey Ok, I understand what is the problem. If the project is set at a sample rate and if you render to a different rate or at runtime change the sample rate the plugin will reset the state to default state because for now Geonkick do not support this feature. I need to do some implementation.

@iurienistor iurienistor added the enhancement New feature or request label Nov 10, 2024
@iurienistor iurienistor changed the title Serious bug, Geonkick returning to initilaised preset when rendering Support runtime change of samplerate Nov 10, 2024
@iurienistor iurienistor added this to the 3.6.0 milestone Nov 10, 2024
@iurienistor iurienistor added feature and removed enhancement New feature or request labels Nov 10, 2024
@gwee007
Copy link

gwee007 commented Nov 10, 2024

Okay, have confirmed what you said and I've changed my render sample rate to be the same as my project sample rate, and it works. Looking forward to 3.6!

@iurienistor iurienistor removed this from the 3.6.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants