Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sse2neon - better machine support #59

Open
btgoodwin opened this issue May 19, 2020 · 7 comments
Open

sse2neon - better machine support #59

btgoodwin opened this issue May 19, 2020 · 7 comments

Comments

@btgoodwin
Copy link
Contributor

The COMPATIBLE_MACHINE = "(arm|aarch64)" usage in this recipe will not work for devices like the Ettus E310 since those values aren't in the MACHINEOVERRIDES. I'm sure this extends to other machines as well. I'm open to other suggestions, but this would be more flexible since in those cases, OVERRIDES will almost certainly have arm or aarch64 in the list (otherwise the dependency chain for rh.DataConverter would not have reached over to those patches and dependencies lists):

COMPATIBLE_MACHINE_arm = "${MACHINE}"
COMPATIBLE_MACHINE_aarch64 = "${MACHINE}"

We would need to apply this as far back as rocko.

@btgoodwin
Copy link
Contributor Author

@jschindehette @ajung123 Thoughts?

@rodrigo455
Copy link
Collaborator

the presence of neon in TUNE_FEATURES, isn't it relevant?

@btgoodwin
Copy link
Contributor Author

btgoodwin commented May 19, 2020

It is. Are you suggesting something even more generic like this?

COMPATIBLE_MACHINE = "${@bb.utils.contains('TUNE_FEATURES', 'neon', '${MACHINE}', '' ,d)}"

edit: I'm not sure if simply '1' is good enough there, or even if the syntax of this is correct now.

@rodrigo455
Copy link
Collaborator

rodrigo455 commented May 19, 2020

I've seen this in cpuburn-neon recipe:

COMPATIBLE_MACHINE = "(${@bb.utils.contains("TUNE_FEATURES", "neon", "${MACHINE}", "Invalid!", d)})"

but now it is different in more recent releases of meta-openembedded (in warrior branch it is renamed to cpuburn-arm), which appears to follow your idea

COMPATIBLE_MACHINE ?= "(^$)"
COMPATIBLE_MACHINE_armv7a = "(.*)"
COMPATIBLE_MACHINE_armv7ve = "(.*)"
COMPATIBLE_MACHINE_aarch64 = "(.*)"

you could also check the ne10 recipe

@btgoodwin
Copy link
Contributor Author

It probably has to do with parsing vs. post-parsing (override syntax) as to how successful the in-line python actually is. So override syntax it is then?

@rodrigo455
Copy link
Collaborator

from my side... I would say so. it is already better than the current approach indeed

@btgoodwin
Copy link
Contributor Author

btgoodwin commented May 22, 2020

Alright, I'll make this part of the 2.2.6 update unless there's a pressing need. A couple of us are chipping through Zeus compatibility right now, which may see us move to gnu++11 (vs. gnu++98) as well as a few other patches.

I pushed zeus-next but it doesn't have much testing yet. The patch is d447444; need to propagate it through the rest of the branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants