Skip to content

Commit

Permalink
Fix matches selector, closes HubSpot#57
Browse files Browse the repository at this point in the history
  • Loading branch information
Zack Bloom committed Feb 22, 2014
1 parent bbee9ba commit 0a03809
Show file tree
Hide file tree
Showing 3 changed files with 77 additions and 74 deletions.
73 changes: 37 additions & 36 deletions br/index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -840,11 +840,12 @@ <h4>IE8+</h4>
return _matches.call(el, selector);
} else {
var nodes = el.parentNode.querySelectorAll(selector);
for (var i = nodes.length; i--;)
if (nodes[i] === el) {
for (var i = nodes.length; i--;) {
if (nodes[i] === el)
return true;
}
return false;
}
}

matches(el, '.my-class');
Expand Down Expand Up @@ -995,40 +996,6 @@ <h4>jQuery</h4>
<h4>IE8+</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>el.offsetWidth
</code></pre>
</div>
</div>
</div>
<div id="parent" class="comparison">
<h3><a href="#parent">Parent</a></h3>
<div data-browser="jquery" class="browser jquery">
<h4>jQuery</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>$(el).parent();
</code></pre>
</div>
</div>
<div data-browser="ie8" class="browser ie8">
<h4>IE8+</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>el.parentNode
</code></pre>
</div>
</div>
</div>
<div id="prepend" class="comparison">
<h3><a href="#prepend">Prepend</a></h3>
<div data-browser="jquery" class="browser jquery">
<h4>jQuery</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>$(parent).prepend(el);
</code></pre>
</div>
</div>
<div data-browser="ie8" class="browser ie8">
<h4>IE8+</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>parent.insertBefore(el, parent.firstChild);
</code></pre>
</div>
</div>
Expand Down Expand Up @@ -1069,6 +1036,40 @@ <h4>IE9+</h4>
}

outerWidth(el);
</code></pre>
</div>
</div>
</div>
<div id="parent" class="comparison">
<h3><a href="#parent">Parent</a></h3>
<div data-browser="jquery" class="browser jquery">
<h4>jQuery</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>$(el).parent();
</code></pre>
</div>
</div>
<div data-browser="ie8" class="browser ie8">
<h4>IE8+</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>el.parentNode
</code></pre>
</div>
</div>
</div>
<div id="prepend" class="comparison">
<h3><a href="#prepend">Prepend</a></h3>
<div data-browser="jquery" class="browser jquery">
<h4>jQuery</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>$(parent).prepend(el);
</code></pre>
</div>
</div>
<div data-browser="ie8" class="browser ie8">
<h4>IE8+</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>parent.insertBefore(el, parent.firstChild);
</code></pre>
</div>
</div>
Expand Down
5 changes: 3 additions & 2 deletions comparisons/elements/matches_selector/ie8.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@ var matches = function(el, selector) {
return _matches.call(el, selector);
} else {
var nodes = el.parentNode.querySelectorAll(selector);
for (var i = nodes.length; i--;)
if (nodes[i] === el) {
for (var i = nodes.length; i--;) {
if (nodes[i] === el)
return true;
}
return false;
}
}

matches(el, '.my-class');
73 changes: 37 additions & 36 deletions index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -866,11 +866,12 @@ <h4>IE8+</h4>
return _matches.call(el, selector);
} else {
var nodes = el.parentNode.querySelectorAll(selector);
for (var i = nodes.length; i--;)
if (nodes[i] === el) {
for (var i = nodes.length; i--;) {
if (nodes[i] === el)
return true;
}
return false;
}
}

matches(el, '.my-class');
Expand Down Expand Up @@ -1021,40 +1022,6 @@ <h4>jQuery</h4>
<h4>IE8+</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>el.offsetWidth
</code></pre>
</div>
</div>
</div>
<div id="parent" class="comparison">
<h3><a href="#parent">Parent</a></h3>
<div data-browser="jquery" class="browser jquery">
<h4>jQuery</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>$(el).parent();
</code></pre>
</div>
</div>
<div data-browser="ie8" class="browser ie8">
<h4>IE8+</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>el.parentNode
</code></pre>
</div>
</div>
</div>
<div id="prepend" class="comparison">
<h3><a href="#prepend">Prepend</a></h3>
<div data-browser="jquery" class="browser jquery">
<h4>jQuery</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>$(parent).prepend(el);
</code></pre>
</div>
</div>
<div data-browser="ie8" class="browser ie8">
<h4>IE8+</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>parent.insertBefore(el, parent.firstChild);
</code></pre>
</div>
</div>
Expand Down Expand Up @@ -1095,6 +1062,40 @@ <h4>IE9+</h4>
}

outerWidth(el);
</code></pre>
</div>
</div>
</div>
<div id="parent" class="comparison">
<h3><a href="#parent">Parent</a></h3>
<div data-browser="jquery" class="browser jquery">
<h4>jQuery</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>$(el).parent();
</code></pre>
</div>
</div>
<div data-browser="ie8" class="browser ie8">
<h4>IE8+</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>el.parentNode
</code></pre>
</div>
</div>
</div>
<div id="prepend" class="comparison">
<h3><a href="#prepend">Prepend</a></h3>
<div data-browser="jquery" class="browser jquery">
<h4>jQuery</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>$(parent).prepend(el);
</code></pre>
</div>
</div>
<div data-browser="ie8" class="browser ie8">
<h4>IE8+</h4>
<div data-lang="javascript" class="code-block language-javascript">
<pre><code>parent.insertBefore(el, parent.firstChild);
</code></pre>
</div>
</div>
Expand Down

0 comments on commit 0a03809

Please sign in to comment.