Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water Purification System #20

Open
Gerold55 opened this issue Apr 7, 2020 · 8 comments
Open

Water Purification System #20

Gerold55 opened this issue Apr 7, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@Gerold55
Copy link
Owner

Gerold55 commented Apr 7, 2020

Is your feature request related to a problem? Please describe.
The player needs a better way to get clean, drinkable water.

Describe the solution you'd like
There could be filter block/filtering machine to purify the water.

Describe alternatives you've considered
Cooking the water could also purify it.
However the unclean components wouldn't be removed that way, it would just kill the living components (bacteria, ...). So it's not enough for actual cleaning.

@Gerold55 Gerold55 added the enhancement New feature or request label Apr 7, 2020
@theFox6
Copy link
Collaborator

theFox6 commented Apr 13, 2020

Even if the dew collector is added there should still be a filter imo.

I think the water in buckets should be finite. Else you'd just purify two buckets of water and then you'd have water generated from the sources. Also once you have one bucket it is enough to drink forever, which is not intended either.

@Gerold55
Copy link
Owner Author

Gerold55 commented Apr 14, 2020

Screenshot (389)
@theFox6

@theFox6
Copy link
Collaborator

theFox6 commented Apr 14, 2020

"It works on my machine"

@Gerold55
Copy link
Owner Author

"It works on my machine"

I think it's due to not having the depends.txt

@Skamiz
Copy link
Contributor

Skamiz commented Apr 14, 2020

Apropos dependencies, It should hard depend on 'ws_core' and 'bucket' since it uses thier items/nodes without testing for thier existence.
Though I don't belive that's what is causing the issue Gerold is having.

@Gerold55
Copy link
Owner Author

Apropos dependencies, It should hard depend on 'ws_core' and 'bucket' since it uses thier items/nodes without testing for thier existence.
Though I don't belive that's what is causing the issue Gerold is having.

Have you been able to recreate the issue?

@Skamiz
Copy link
Contributor

Skamiz commented Apr 14, 2020

No, latest master runs without issues for me.

@theFox6
Copy link
Collaborator

theFox6 commented Apr 14, 2020

It should hard depend on ws_core cause it crashes if ws_core is not loaded.
But it can run without bucket.
Even without causing problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants