Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit link for logged in user on dataset page #74

Closed
ghost opened this issue Mar 26, 2021 · 6 comments · May be fixed by #75
Closed

Edit link for logged in user on dataset page #74

ghost opened this issue Mar 26, 2021 · 6 comments · May be fixed by #75
Assignees
@dgading

Comments

@ghost
Copy link

ghost commented Mar 26, 2021 •
edited by susisiman
Loading

On DKAN1, users were accustomed to going to a dataset page and seeing an edit button they could use make changes. Currently, to edit a dataset, users need to go to a manage content page in order to find and edit link to datasets. In user tests testing, this was found to be confusing for users who were accustomed to DKAN1.

  • User story*
    As a data publisher, when I am looking at a dataset page, I would like to be able to choose to edit it from that page, so that I don't need to leave the page to make changes.

Acceptance criteria

  • Tests and code for 1.x and 2.x to render an edit link conditionally on the datasets page.

Estimate
8 story points.
@ghost ghost assigned alexiscott Mar 26, 2021
@ghost ghost mentioned this issue Mar 29, 2021
Closed
@alexiscott
Copy link
Contributor

alexiscott commented Apr 6, 2021 •
edited
Loading

Discussed the implementation approach with @dgading for global state.
Wrapping <UserContext><Route>... should make it possible to go ahead and the User logged in state from within any component with `useContext(UserContext). That strategy frees me up to start working on this.
CC @cmugisha

@alexiscott alexiscott linked a pull request Apr 16, 2021 that will close this issue
Logged in user provider via JSONAPI. #75
Open
@alexiscott
Copy link
Contributor

alexiscott commented Apr 16, 2021 •
edited
Loading

@cmugisha just a heads up that I have assigned the PR for this ticket to Daniel Gading. Once it is merged and released, we will be able to add the component (and tests) that will provide the link to the logged in user's dataset in Drupal. I don't think that we will need a new ticket for that work.

@dafeder dafeder assigned dgading and unassigned alexiscott Apr 19, 2021
@ghost
Copy link
Author

ghost commented Apr 22, 2021

@dgading Any progress in reviewing this?

@ghost
Copy link
Author

ghost commented Apr 22, 2021

Slack comment from Daniel Gading: I talked to Alex about it. This PR will be closed and the work should be done on the individual catalog apps for now. If I merged this into data-catalog-app it would still require refactors on each of the site catalogs since this code isn't pulled in but once when the site is initially built. I think it is a good start, but should be moved to a custom hook or something in a different repo so it is a little more reuseable, but with our new time tables, that isn't really feasible right now

@ghost
Copy link
Author

ghost commented Apr 22, 2021

Chadia's Slack response to Daniel: Ok. It sounds like this ticket needs to be moved back to In Progress or should I close it so that you and Alex can create new tickets that better reflect the individual work you just mentioned?

@ghost
Copy link
Author

ghost commented Apr 22, 2021

Response from Daniel: I think this can be closed. And open one in each repo that we are migrating that needs it

@ghost ghost closed this as completed Apr 22, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgading dgading

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Logged in user provider via JSONAPI. GetDKAN/data-catalog-app
2 participants
@dgading @alexiscott