You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
since #4317 the pagination of the import status dashboard is not correct anymore, if there are datasets filtered out due to non-importable distributions. Pagination is still pointing to all datasets irrespective of the filter. This may lead to empty pages in the pager and pages with less items than pagination items per page setting.
Expected Behavior
Pager should reflect the actual state of filtered datasets.
Steps To Reproduce
Have more than 10 datasets, some of them having no importable distributions (like PDF, DOC, etc.).
See that pagination of import status dashboard is not correct.
Relevant log output (optional)
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered:
@stefan-korn I agree this needs to be fixed but yeah, this is closer to the way the dashboard worked once upon a time and the performance was terrible. I think we need a new approach, something where we query for resources and can filter them by whether they're store-able or not, and then get any metadata we need for them. I'm going to keep this issue open and hope to come back to it soon. Unless you have some evidence that the performance issues can be mitigated (maybe through caching of the DatasetInfo objects if we can get the invalidation right) I think we may close the PR.
Current Behavior
since #4317 the pagination of the import status dashboard is not correct anymore, if there are datasets filtered out due to non-importable distributions. Pagination is still pointing to all datasets irrespective of the filter. This may lead to empty pages in the pager and pages with less items than pagination items per page setting.
Expected Behavior
Pager should reflect the actual state of filtered datasets.
Steps To Reproduce
Have more than 10 datasets, some of them having no importable distributions (like PDF, DOC, etc.).
See that pagination of import status dashboard is not correct.
Relevant log output (optional)
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: