Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DatasetInfo work without Datastore module enabled #4360

Open
dafeder opened this issue Dec 18, 2024 · 0 comments
Open

Make DatasetInfo work without Datastore module enabled #4360

dafeder opened this issue Dec 18, 2024 · 0 comments
Assignees
Labels

Comments

@dafeder
Copy link
Member

dafeder commented Dec 18, 2024

In the context of #3746, we want to make common not depend on datastore. One place it does heavily is in the DatasetInfo class. Let's make sure this service can work if datastore is not enabled, and simply return less info.

In the future, we should either set up some kind of plugin or subscriber system so that any module can add info to the core dataset info object. OR (even better) we should maybe find a way to stop using this class altogether. It is kind of an anti-pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants