From 8e912e5870ceebd1335590a0ee4b855e4441861a Mon Sep 17 00:00:00 2001
From: huper1 <166437812+huper1@users.noreply.github.com>
Date: Sun, 2 Mar 2025 16:36:29 +0300
Subject: [PATCH] Correct validation logic for click-packet

fix: correct sign for CLICK_OUTSIDE_NOT_HOLDING_SLOT in validation

The CLICK_OUTSIDE_NOT_HOLDING_SLOT constant was incorrectly used without a minus sign,
causing valid slots to be rejected during validation. This fix ensures the correct
value (-999) is used, allowing proper validation.
---
 .../serverbound/inventory/ServerboundContainerClickPacket.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/protocol/src/main/java/org/geysermc/mcprotocollib/protocol/packet/ingame/serverbound/inventory/ServerboundContainerClickPacket.java b/protocol/src/main/java/org/geysermc/mcprotocollib/protocol/packet/ingame/serverbound/inventory/ServerboundContainerClickPacket.java
index e0408e3bc..32f2f70a5 100644
--- a/protocol/src/main/java/org/geysermc/mcprotocollib/protocol/packet/ingame/serverbound/inventory/ServerboundContainerClickPacket.java
+++ b/protocol/src/main/java/org/geysermc/mcprotocollib/protocol/packet/ingame/serverbound/inventory/ServerboundContainerClickPacket.java
@@ -45,7 +45,7 @@ public ServerboundContainerClickPacket(int containerId, int stateId, int slot,
                                            @NonNull ContainerActionType action, @NonNull ContainerAction param,
                                            @Nullable ItemStack carriedItem, @NonNull Int2ObjectMap<@Nullable ItemStack> changedSlots) {
         if ((param == DropItemAction.LEFT_CLICK_OUTSIDE_NOT_HOLDING || param == DropItemAction.RIGHT_CLICK_OUTSIDE_NOT_HOLDING)
-                && slot != -CLICK_OUTSIDE_NOT_HOLDING_SLOT) {
+                && slot != CLICK_OUTSIDE_NOT_HOLDING_SLOT) {
             throw new IllegalArgumentException("Slot must be " + CLICK_OUTSIDE_NOT_HOLDING_SLOT
                     + " with param LEFT_CLICK_OUTSIDE_NOT_HOLDING or RIGHT_CLICK_OUTSIDE_NOT_HOLDING");
         }