#120 Connection string DataSource key is case sensitive

Giorgi · Sep 17, 2023 · 4ee9e41 · 4ee9e41
1 parent b174409
commit 4ee9e41
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/DuckDB.NET.Data/ConnectionString/DuckDBConnectionStringParser.cs b/DuckDB.NET.Data/ConnectionString/DuckDBConnectionStringParser.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using System.Linq;
 
 namespace DuckDB.NET.Data.ConnectionString;
@@ -39,9 +40,13 @@ public static DuckDBConnectionString Parse(string connectionString)
 
     private static string GetDataSource(IReadOnlyDictionary<string, string> properties)
     {
+        var lowerCaseProperties = properties.ToDictionary(kv => kv.Value.ToLower(CultureInfo.InvariantCulture), kv => kv.Value);
+
         foreach (var key in DuckDBConnectionStringBuilder.DataSourceKeys)
         {
-            if (properties.TryGetValue(key, out var dataSource))
+            var lowerKey = key.ToLower(CultureInfo.InvariantCulture);
+
+            if (lowerCaseProperties.TryGetValue(lowerKey, out var dataSource))
             {
                 return dataSource;
             }

diff --git a/DuckDB.NET.Data/DuckDBConnectionStringBuilder.cs b/DuckDB.NET.Data/DuckDBConnectionStringBuilder.cs
@@ -10,7 +10,7 @@ public class DuckDBConnectionStringBuilder : DbConnectionStringBuilder
     public const string InMemorySharedDataSource = ":memory:?cache=shared";
     public const string InMemorySharedConnectionString = "DataSource=:memory:?cache=shared";
 
-    internal static readonly string[] DataSourceKeys = {"Data Source", "DataSource", "datasource", "data source"};
+    internal static readonly string[] DataSourceKeys = {"Data Source", "DataSource"};
     private const string DataSourceKey = "DataSource";
 
     private string dataSource = null;