Origin-center grids by default; fix a type conversion; update tests #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x
andy
offset forcenter
to be 0, not 1. This means that the zero index hexagon (e.g.HexagonCubic(0, 0, 0)
) will be centered at the xy origin. This should fix both inconsistency in cube_round #13 and hexbin misalignment Gadfly.jl#1497 .compare to Amit Patel's reference:
i.e. the
-q-r
term should become the cubicy
(second argument), but current master puts this term in cubicz
.