Skip to content

Commit

Permalink
Merge branch 'PHP-8.3'
Browse files Browse the repository at this point in the history
* PHP-8.3:
  Fix #52751: XPath processing-instruction() function is not supported.
  • Loading branch information
nielsdos committed Sep 10, 2023
2 parents 038e9b7 + 2440af0 commit 6b54811
Show file tree
Hide file tree
Showing 2 changed files with 59 additions and 1 deletion.
2 changes: 1 addition & 1 deletion ext/simplexml/simplexml.c
Original file line number Diff line number Diff line change
Expand Up @@ -1308,7 +1308,7 @@ PHP_METHOD(SimpleXMLElement, xpath)

for (i = 0; i < result->nodeNr; ++i) {
nodeptr = result->nodeTab[i];
if (nodeptr->type == XML_TEXT_NODE || nodeptr->type == XML_ELEMENT_NODE || nodeptr->type == XML_ATTRIBUTE_NODE) {
if (nodeptr->type == XML_TEXT_NODE || nodeptr->type == XML_ELEMENT_NODE || nodeptr->type == XML_ATTRIBUTE_NODE || nodeptr->type == XML_PI_NODE) {
/**
* Detect the case where the last selector is text(), simplexml
* always accesses the text() child by default, therefore we assign
Expand Down
58 changes: 58 additions & 0 deletions ext/simplexml/tests/bug52751.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
--TEST--
Bug #52751 (XPath processing-instruction() function is not supported)
--EXTENSIONS--
simplexml
--FILE--
<?php

$xml = <<<XML
<?xml version="1.0" encoding="utf-8"?>
<foo>
<bar>text node</bar>
<bar><?baz href="ftw" ?></bar>
<bar><?foo bar ?></bar>
</foo>
XML;

$sxe = simplexml_load_string($xml);

var_dump(
$sxe->xpath('//bar')
);

var_dump(
$sxe->xpath('//processing-instruction(\'baz\')')
);

foreach ($sxe->xpath('//processing-instruction()') as $pi) {
var_dump($pi->getName());
}

?>
--EXPECT--
array(3) {
[0]=>
object(SimpleXMLElement)#2 (1) {
[0]=>
string(9) "text node"
}
[1]=>
object(SimpleXMLElement)#3 (1) {
["baz"]=>
object(SimpleXMLElement)#5 (0) {
}
}
[2]=>
object(SimpleXMLElement)#4 (1) {
["foo"]=>
object(SimpleXMLElement)#5 (0) {
}
}
}
array(1) {
[0]=>
object(SimpleXMLElement)#4 (0) {
}
}
string(3) "baz"
string(3) "foo"

0 comments on commit 6b54811

Please sign in to comment.