Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W.I.P: Zend: container/offset semantics RFC: object handlers #19

Closed
wants to merge 39 commits into from
Closed

W.I.P: Zend: container/offset semantics RFC: object handlers #19

wants to merge 39 commits into from

Conversation

Girgias
Copy link
Owner

@Girgias Girgias commented Feb 2, 2024 •
edited
Loading

Conversions:

  • ext/dom: All classes
  • ext/simplexml: SimpleXML
  • ext/pdo: PDORow
  • ext/intl: ResourceBundle
  • Zend: WeakMap
  • ext/ffi FFI classes
  • ext/spl: ArrayObject
  • ext/spl: ArrayIterator
  • ext/spl: RecursiveArrayIterator
  • ext/spl: SplObjectStorage
  • ext/spl: SplFixedArray

Classes that implement ArrayAccess without specialized handlers

  • ext/phar: Phar
  • ext/phar: PharData
  • ext/spl: CachingIterator

Other To-dos:

  • Fix Windows build
  • JIT Support
  • opcache support (opcache_persist stuff)
  • Fix issue not being able to call offsetFetch() as it is not marked to return by reference?
  • Be sure about the indirect thing for ArrayObject, and possibly use it for SplFixedArray
  • RFC Updating

@Girgias Girgias force-pushed the zend_container_offset_semantics branch from 8ba4772 to f7291a2 Compare February 6, 2024 23:35
@Girgias Girgias force-pushed the zend_container_offset_semantics branch from 9f3c3ee to 1299207 Compare February 6, 2024 23:47
Girgias added 27 commits July 11, 2024 16:43
@Girgias
ext/spl: Convert SplObjectStorage to new API
56331e7
@Girgias
ext/spl: Clean-up SplObjectStorage implementation
838e4d4
@Girgias
Use static struct for SplObjectStorage dimension handlers
e157227
@Girgias
ext/spl: [WIP] Convert ArrayObject to new API
04f72f5
@Girgias
ext/ffi: Convert CData to new API
3242ad9 
Ideally this really should be split into 3 concrete subclasses and CData becoming an interface
@Girgias
Use static struct for function handlers in zend_test
f302e5d
@Girgias
Use static structs for internal classes
8f9a6d7 
Except for ArrayAccess, still need to convert some
@Girgias
ext/phar: expand test to cover issue with offsetGet
c27c676
@Girgias
ext/phar: offsetExists should return false when file entry is not bas…
a360dfd 
…ed on PharFileInfo
@Girgias
Fix append binary op
0016634
@Girgias
Fix issue when returning object by-ref in fetch
5027993
@Girgias
Clean-up implementation of zend_legacy_ArrayAccess_fetch_dimension
25172d8
@Girgias
Fix by ref assignments for ArrayObject only
89ecd6a
@Girgias
Support indirect, add tests for objects with binary op
a9e946a
@Girgias
Fix ArrayAccess for good
9de2fd5
@Girgias
Fix indirect modification of offset when handler uses global
096f98a
@Girgias
Improve debug assertion now that conversion is mostly done
16ed7fc
@Girgias
JIT Support
5047f2f
@Girgias
Do we even need to create a ref?
9b4e06a
@Girgias
Add missing GMP extension
7eff740
@Girgias
ArrayObject arginfos
fd6a17c
@Girgias
Define default ArrayAccess handlers for internal classes
703e250
@Girgias
ext/com: Convert to new API [W.I.P.]
809047c 
Shot in the dark via CI
@Girgias
Remove old dimension handlers
172e5b5
@Girgias
Fix persistence code in opcache
1b11052
@Girgias
opcache file persistence W.I.P.
b757191
@Girgias
Remove unused zend_class_arrayaccess_funcs struct now
cb78781
@Girgias Girgias force-pushed the zend_container_offset_semantics branch from 7b20c51 to cb78781 Compare July 11, 2024 15:44
@Girgias
Copy link
Owner Author

Girgias commented Jul 11, 2024

See PR on the main repo: php#14920

@Girgias Girgias closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrisonlevi morrisonlevi morrisonlevi left review comments

Assignees
No one assigned
Labels
Category: Build System Category: Engine Category: Optimizer Extension: bcmath Extension: bz2 Extension: calendar Extension: com_dotnet Extension: ctype Extension: curl Extension: date Extension: dba Extension: dom Extension: enchant Extension: exif Extension: ffi Extension: fileinfo Extension: filter Extension: ftp Extension: gd Extension: gettext Extension: gmp Extension: hash Extension: iconv Extension: intl Extension: json Extension: ldap Extension: libxml Extension: mbstring Extension: mysqli Extension: mysqlnd Extension: odbc Extension: opcache Extension: openssl Extension: pcntl Extension: pcre Extension: pdo (core) Extension: pdo_dblib Extension: pdo_firebird Extension: pdo_mysql Extension: pdo_odbc Extension: pdo_pgsql Extension: pdo_sqlite Extension: pgsql Extension: phar Extension: posix Extension: random Extension: readline Extension: reflection Extension: session Extension: shmop Extension: simplexml Extension: snmp Extension: soap Extension: sockets Extension: sodium Extension: spl Extension: sqlite3 Extension: standard Extension: sysvmsg Extension: sysvsem Extension: sysvshm Extension: tidy Extension: tokenizer Extension: xml Extension: xmlreader Extension: xmlwriter Extension: xsl Extension: zend_test Extension: zip Extension: zlib SAPI: apache2handler SAPI: cgi SAPI: cli SAPI: fpm SAPI: fuzzer SAPI: litespeed SAPI: phpdbg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @morrisonlevi