Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every one can create conversation with any status in any milestone #268

Open
mohammadranjbarz opened this issue Nov 18, 2020 · 0 comments
Open

Comments

@mohammadranjbarz
Copy link
Collaborator

@aminlatifi As I see in conversation.hooks https://github.com/Giveth/feathers-giveth/blob/develop/src/services/conversations/conversations.hooks.js#L65

Only people involved with the milestone can create conversation, but with API anyone can create any conversation for any milestone, I was testing this for this milestone
https://develop.giveth.io/campaigns/5d2eb691e31bd24ef8bd3fa8/milestones/5f918fb5a1bdcf6d6f0f92bb
and after creating some conversation with some statuses (like payment, ...) the milestone broke up and you cant load it (plz check it), Or I created a comment in below milestone that I have no role in that
https://develop.giveth.io/campaigns/5d2ead3f39caf86902b10cef/milestones/5f39883a533cb66db4dc1eb4
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant