Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zkevm chain #24

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Support zkevm chain #24

merged 3 commits into from
Aug 28, 2024

Conversation

@aminlatifi
Copy link
Member

Is it a duplicate of #25?

@mohammadranjbarz
Copy link
Contributor Author

Is it a duplicate of #25?

Target branch of one of them is staging, the other one is main

@aminlatifi
Copy link
Member

aminlatifi commented Aug 27, 2024

Hmm, isn't the convention to first merge to staging and then merge it to main?!

@mohammadranjbarz
Copy link
Contributor Author

Hmm, isn't the convention to first merge to staging and then merge it to main?!

I didn't know the convention for this project, and staging had some commits that are not in the production, so I made two PRs for that

@aminlatifi
Copy link
Member

Hmm, isn't the convention to first merge to staging and then merge it to main?!

I didn't know the convention for this project, and staging had some commits that are not in the production, so I made two PRs for that

The main and staging look like the same, few commits are difference that don't change any file. I suggest first merge to staging and merge that to main

@mohammadranjbarz
Copy link
Contributor Author

Hmm, isn't the convention to first merge to staging and then merge it to main?!

I didn't know the convention for this project, and staging had some commits that are not in the production, so I made two PRs for that

The main and staging look like the same, few commits are difference that don't change any file. I suggest first merge to staging and merge that to main

Cool I will do that

@mohammadranjbarz mohammadranjbarz merged commit 14a8bd4 into staging Aug 28, 2024
@mohammadranjbarz mohammadranjbarz deleted the 23_support_zkevm_chain branch August 28, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants