-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set zero power snapshot balance when balance aggregator doesn't return any balance for an address #1655
Labels
Comments
I think you're the tech lead for this one, assigning you @mohammadranjbarz Also cc: @laurenluz for GIVeconomy Pm |
@aminlatifi was this done already? |
@laurenluz I am not informed if anything is done about it. @jainkrati Would be more informed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impact-graph fills power snapshot balances by querying the balance aggregator as below
impact-graph/src/services/cronJobs/fillSnapshotBalances.ts
Lines 124 to 143 in bc3b435
When the balance aggregator doesn't have any balance for an address, it doesn't return anything for that one. In the current implementation, the power balance snapshot for that user will remain empty forever. We must identify when no balance is returned for an address and fill it with zero!
The text was updated successfully, but these errors were encountered: