Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce complexity #84

Closed
hhirsch opened this issue Jun 4, 2017 · 1 comment
Closed

Reduce complexity #84

hhirsch opened this issue Jun 4, 2017 · 1 comment
Labels
Milestone

Comments

@hhirsch
Copy link
Member

hhirsch commented Jun 4, 2017

Due to too optimistic merging into the master branch by me it is in a broken state and populated with code of high complexity. To me it is very clear what went wrong and how we will avoid it in the future.

The stable branch is a compromise of a more modern client the main problem being incomplete and unsolvable maps.

The last release we had has too few maps and a very short play time so even if we port all the old maps to stable we still don't have much of a game. Meaning we need new maps #82.

Since our main game mechanic is very limited at the moment especially on stable it might be wise to not base all off our content on the teleportation puzzles but to also make exploration part of the experience.

We will roll back the ECS on master in favour of a simpler System that utilises multiple inheritance. #85
Edit:
Dorian: Multithread isn't going away, I'll just limit the System/Simulation runner thread count to 1 for now.
It's a soft limit.

Geert: So what was the problem with ECS?

Dorian:
General complexity it has when you must combine multiple components every single time.
Breaking down behaviours is nice but implies you make code to handle that behaviour split.
C++ multiple and virtual inheritance already does that for you at a lesser overhead cost than ECS since it can use platform-specific optimizations through the compiler's implementation.

#55 #66

@hhirsch hhirsch added the EPIC label Jun 4, 2017
@hhirsch hhirsch added this to the release milestone Jun 5, 2017
@hhirsch
Copy link
Member Author

hhirsch commented Nov 25, 2017

While this Epic is not really solved it is already shattered into million little issues that are all over our bug tracker.

@hhirsch hhirsch closed this as completed Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant