Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coregistration: Tilt and VerticalShift pipelines in 0.0.16 #447

Closed
MatteaE opened this issue Nov 13, 2023 · 2 comments · Fixed by #450
Closed

Coregistration: Tilt and VerticalShift pipelines in 0.0.16 #447

MatteaE opened this issue Nov 13, 2023 · 2 comments · Fixed by #450

Comments

@MatteaE
Copy link
Contributor

MatteaE commented Nov 13, 2023

I've encountered a regression with coregistration between 0.0.13 and 0.0.16, affecting (at least) Tilt and VerticalShift when used in combination with NuthKaab.

Attached the relevant dh plots: coregistration result is wrong in 0.0.16 with any combination of NuthKaab + one of the two methods mentioned above; when used individually, NuthKaab and VerticalShift behave as expected also in 0.0.16. Also attached the input files to reproduce.

demdiff_orig_plot

xdem_coreg_issue_data.zip

@rhugonnet
Copy link
Member

Thanks a lot for the reproducible example @MatteaE!
Probably a bug introduced in #436. Our tests for the coregistration are a bit old (2 years) and didn't catch this... It's one of our top priorities to update them.
I'll look at this in details later this week 🙂

@rhugonnet rhugonnet changed the title Coregistration: Tilt and VerticalShift regression in 0.0.16 Coregistration: Tilt and VerticalShift pipelines in 0.0.16 Nov 27, 2023
@rhugonnet
Copy link
Member

Found the bug, 4 letters were missing in a variable of CoregPipeline.fit(). Added tests in #450 so that won't happen again 😄.
I'll release a 0.0.17 with the fix soon.

Thanks again @MatteaE!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants