Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in CoregPipeline.fit() #450

Merged
merged 6 commits into from
Nov 28, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Linting
  • Loading branch information
rhugonnet committed Nov 28, 2023
commit 15e92858dab2641263f7506c73313f878954d6c9
3 changes: 2 additions & 1 deletion tests/test_coreg/test_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,7 @@ def test_coreg_add(self) -> None:
vshift5 = vshift3 + vshift3
assert vshift5.to_matrix()[2, 3] == vshift * 4

def test_pipeline_consistency(self):
def test_pipeline_consistency(self) -> None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to add tests for this!

"""Check that pipelines properties are respected: reflectivity, fusion of same coreg"""

# Test 1: Fusion of same coreg
Expand Down Expand Up @@ -714,6 +714,7 @@ def test_pipeline_consistency(self):

assert np.allclose(nk_vshift.to_matrix(), vshift_nk.to_matrix(), atol=10e-1)


class TestBlockwiseCoreg:
ref, tba, outlines = load_examples() # Load example reference, to-be-aligned and mask.
inlier_mask = ~outlines.create_mask(ref)
Expand Down