Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tourniquet parts FreeCAD models initial release #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0penBrain
Copy link

Hi. Following @tareko call for collaboration on otoscope, I found the tourniquet a nice exercise to model in FreeCAD. :)
I guess the interesting part of doing is to increase openness and hacking possibility of parts to a wider range of people.

So in this PR is an initial release with following assessments/limitations/remarks :

General :

  • All parts are modeled with a parametric approach using PartDesign workbench of FreeCAD
  • Try to stick as close as possible to original part
  • As stable/robust/hackable modeling as possible

anchor_holder :

  • Nothing special to say about :)

anchor_rod :

  • Central shape has been produced by an arc of ellipse. I think this is conform to original shape
  • There was an "unnatural" shape (some parallelepiped substraction) around central slot at its outside. I replaced that with a chamfer guessing it was the expected function. Hope this is correct. ;)

slice :

  • Nothing special to say about :)

buckle/wide_buckle :

  • Top text isn't fine tuned. On the (small) buckle, I can't reproduce the exact same text despite I used the same font. On the wide buckle, ATM I kept same text as for the small buckle.
  • I can't "mathematically" center the text because FreeCAD crashes when trying to use expressions to do so. ATM, it is "manually" centered using placement of the 'ShapeString' object.
  • FreeCAD doesn't support ATM embedded or relative-path font. So if text modification is needed, font path shall be set in the 'Font File' property of the 'ShapeString' object.
  • Font is pushed in this PR in the 'assets' folder
  • At the bottom of the small buckle, there was a small material "tooth". It looks to me as a modeling glitch to I removed it, but maybe I'm wrong. :)
  • On both buckles, the gripping pattern wasn't centered. I guessed it wasn't for any particular purpose so I centered it. But maybe I'm wrong again. :)

Notice these files haven't been reviewed in any way. So if you're interested in using them, you should check them.
Anyway feel free to remark/modify/request for changes. ;)

HTH

@tareko
Copy link
Member

tareko commented Sep 4, 2019

Hi 0penBrain!

Thank you for such incredible work. This is absolutely a valuable contribution to the project.

I am conflicted about what to do at this point. We hadn't requested CAD assistance because we have OpenSCAD files. However, the files are great and I think we should leave them here. I'll have the Gaza team (who made the original files) take a look and we'll discuss the best way forward during our weekly team meeting tomorrow.

tarek : )

@darigovresearch
Copy link
Contributor

@tareko did you manage to speak to the team to discuss what to do with @0penBrain 's pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants