Fix lines starting with ? being incorrectly interpreted

[adombeck]

Please describe the change you are making

Lines starting with ? are interpreted as a package being skipped:

gotestfmt/tokenizer/tokenizer.go

Lines 183 to 188 in 4c97682

	{
	regexp.MustCompile(`^\?\s+(?P<Package>[^\s]+)\s+\[(?P<Output>.*)]$`),
	stateBetweenTests,
	ActionSkip,
	stateBetweenTests,
	},

If a test prints a line that matches this pattern, then that output is incorrectly interpreted as a test being skipped and is therefore printed like this instead of hiding it (yes, the test does actually print a lot of question marks):

Looking at the JSON output produced by go test for packages being skipped:

{
  "Time": "2024-11-27T15:44:59.055963303+01:00",
  "Action": "output",
  "Package": "github.com/ubuntu/authd/.scratch/reproduce-gotestfmt-bug/bar",
  "Output": "?   \tgithub.com/ubuntu/authd/.scratch/reproduce-gotestfmt-bug/bar\t[no test files]\n"
}

and the JSON output of a test that prints a line starting with ?:

{
  "Time": "2024-11-27T15:44:59.137559943+01:00",
  "Action": "output",
  "Package": "github.com/ubuntu/authd/.scratch/reproduce-gotestfmt-bug/foo",
  "Test": "TestFoo",
  "Output": "?  foo bar\n"
}

we see that we can distinguish between these two cases on the basis of the Test field.

So this PR only interprets lines starting with ? as a package being skipped when it's not output from a test, i.e. its JSON line doesn't have a Test field. There was no functionality yet to encode such a condition, so this PR adds a precondition function to the stateChange struct.

Your code will be released under the Unlicense into the public domain for everyone to use for any purpose. Are you in the position, and are you willing to release your code under this license?

yes