From bed56e55fd56c44cd46fd0ce9da9f74b7af867c0 Mon Sep 17 00:00:00 2001
From: Dev Aggarwal <devxpy@gmail.com>
Date: Mon, 12 Feb 2024 15:49:25 +0530
Subject: [PATCH] refactor: reusable menutab display labels

---
 daras_ai_v2/base.py         |  7 +++-
 daras_ai_v2/breadcrumbs.py  | 65 +++++++++++++------------------------
 daras_ai_v2/meta_content.py | 35 ++++++++------------
 daras_ai_v2/tabs_widget.py  |  8 +++++
 4 files changed, 51 insertions(+), 64 deletions(-)

diff --git a/daras_ai_v2/base.py b/daras_ai_v2/base.py
index 906b73a08..d6243aeb7 100644
--- a/daras_ai_v2/base.py
+++ b/daras_ai_v2/base.py
@@ -243,7 +243,12 @@ def _render_header(self):
 
                 if tbreadcrumbs:
                     with st.tag("div", className="me-3 mb-1 mb-lg-0 py-2 py-lg-0"):
-                        render_breadcrumbs(tbreadcrumbs, current_run.is_api_call)
+                        render_breadcrumbs(
+                            tbreadcrumbs,
+                            is_api_call=(
+                                current_run.is_api_call and self.tab == MenuTabs.run
+                            ),
+                        )
 
                 author = self.run_user or current_run.get_creator()
                 if not is_root_example:
diff --git a/daras_ai_v2/breadcrumbs.py b/daras_ai_v2/breadcrumbs.py
index 84deb5c4d..94e63cb80 100644
--- a/daras_ai_v2/breadcrumbs.py
+++ b/daras_ai_v2/breadcrumbs.py
@@ -31,7 +31,7 @@ def has_breadcrumbs(self):
         return bool(self.root_title or self.published_title)
 
 
-def render_breadcrumbs(breadcrumbs: TitleBreadCrumbs, is_api_call: bool = False):
+def render_breadcrumbs(breadcrumbs: TitleBreadCrumbs, *, is_api_call: bool = False):
     st.html(
         """
         <style>
@@ -92,61 +92,42 @@ def get_title_breadcrumbs(
     root_breadcrumb = TitleUrl(metadata.short_title, page_cls.app_url())
 
     match tab:
-        case MenuTabs.run if is_root:
-            return TitleBreadCrumbs(page_cls.get_recipe_title(), None, None)
-        case MenuTabs.run if is_example:
-            assert pr is not None
-            return TitleBreadCrumbs(
-                pr.title or prompt_title or recipe_title,
-                root_title=root_breadcrumb,
-                published_title=None,
-            )
-        case MenuTabs.run if is_run:
-            return TitleBreadCrumbs(
-                prompt_title or f"Run: {recipe_title}",
-                root_title=root_breadcrumb,
-                published_title=TitleUrl(
-                    pr.title or f"Fork: {pr.published_run_id}",
-                    pr.get_app_url(),
-                )
-                if pr and not pr.is_root()
-                else None,
-            )
-        case MenuTabs.examples:
+        case MenuTabs.examples | MenuTabs.history | MenuTabs.saved:
+            label = MenuTabs.display_labels[tab]
             return TitleBreadCrumbs(
-                f"Examples: {metadata.short_title}",
+                f"{label}: {metadata.short_title}",
                 root_title=root_breadcrumb,
                 published_title=None,
             )
-        case MenuTabs.run_as_api:
-            tbreadcrumbs_on_run = get_title_breadcrumbs(
-                page_cls=page_cls, sr=sr, pr=pr, tab=MenuTabs.run
-            )
+        case MenuTabs.run_as_api | MenuTabs.integrations:
+            label = MenuTabs.display_labels[tab]
+            tbreadcrumbs_on_run = get_title_breadcrumbs(page_cls=page_cls, sr=sr, pr=pr)
             return TitleBreadCrumbs(
-                f"API: {tbreadcrumbs_on_run.h1_title}",
+                f"{label}: {tbreadcrumbs_on_run.h1_title}",
                 root_title=tbreadcrumbs_on_run.root_title or root_breadcrumb,
                 published_title=tbreadcrumbs_on_run.published_title,
             )
-        case MenuTabs.integrations:
-            tbreadcrumbs_on_run = get_title_breadcrumbs(
-                page_cls=page_cls, sr=sr, pr=pr, tab=MenuTabs.run
-            )
-            return TitleBreadCrumbs(
-                f"Integrations: {tbreadcrumbs_on_run.h1_title}",
-                root_title=tbreadcrumbs_on_run.root_title or root_breadcrumb,
-                published_title=tbreadcrumbs_on_run.published_title,
-            )
-        case MenuTabs.history:
+        case _ if is_root:
+            return TitleBreadCrumbs(page_cls.get_recipe_title(), None, None)
+        case _ if is_example:
+            assert pr is not None
             return TitleBreadCrumbs(
-                f"History: {metadata.short_title}",
+                pr.title or prompt_title or recipe_title,
                 root_title=root_breadcrumb,
                 published_title=None,
             )
-        case MenuTabs.saved:
+        case _ if is_run:
+            if pr and not pr.is_root():
+                published_title = TitleUrl(
+                    pr.title or f"Fork: {pr.published_run_id}",
+                    pr.get_app_url(),
+                )
+            else:
+                published_title = None
             return TitleBreadCrumbs(
-                f"Saved Runs: {metadata.short_title}",
+                prompt_title or f"Run: {recipe_title}",
                 root_title=root_breadcrumb,
-                published_title=None,
+                published_title=published_title,
             )
         case _:
             raise ValueError(f"Unknown tab: {tab}")
diff --git a/daras_ai_v2/meta_content.py b/daras_ai_v2/meta_content.py
index ff946bb75..4bdab3f74 100644
--- a/daras_ai_v2/meta_content.py
+++ b/daras_ai_v2/meta_content.py
@@ -111,27 +111,20 @@ def meta_title_for_page(
     pr: PublishedRun | None,
     tab: str,
 ) -> str:
-    suffix = f" {sep} Gooey.AI"
-
     match tab:
         case MenuTabs.examples:
-            return f"Examples: {metadata.meta_title}" + suffix
-        case MenuTabs.run_as_api:
-            return "API: " + meta_title_for_page(
-                page=page, metadata=metadata, sr=sr, pr=pr, tab=MenuTabs.run
-            )
-        case MenuTabs.integrations:
-            return "Integrations: " + meta_title_for_page(
-                page=page, metadata=metadata, sr=sr, pr=pr, tab=MenuTabs.run
-            )
-        case MenuTabs.history:
-            return f"History for {metadata.short_title}" + suffix
-        case MenuTabs.saved:
-            return f"Saved Runs for {metadata.short_title}" + suffix
-        case MenuTabs.run if pr and pr.saved_run == sr and pr.is_root():
+            label = MenuTabs.display_labels[tab]
+            ret = f"{label}: {metadata.meta_title}"
+        case MenuTabs.run_as_api | MenuTabs.integrations:
+            label = MenuTabs.display_labels[tab]
+            return f"{label} for {meta_title_for_page(page=page, metadata=metadata, sr=sr, pr=pr, tab=MenuTabs.run)}"
+        case MenuTabs.history | MenuTabs.saved:
+            label = MenuTabs.display_labels[tab]
+            ret = f"{label} for {metadata.short_title}"
+        case _ if pr and pr.saved_run == sr and pr.is_root():
             # for root page
-            return metadata.meta_title + suffix
-        case MenuTabs.run:
+            ret = metadata.meta_title
+        case _:
             # non-root runs and examples
             parts = []
 
@@ -148,9 +141,9 @@ def meta_title_for_page(
                 part += f" by {user.display_name}"
             parts.append(part)
 
-            return sep.join(parts) + suffix
-        case _:
-            raise ValueError(f"Unknown tab: {tab}")
+            ret = sep.join(parts)
+
+    return f"{ret} {sep} Gooey.AI"
 
 
 def meta_description_for_page(
diff --git a/daras_ai_v2/tabs_widget.py b/daras_ai_v2/tabs_widget.py
index f6511e58e..ed643f881 100644
--- a/daras_ai_v2/tabs_widget.py
+++ b/daras_ai_v2/tabs_widget.py
@@ -22,6 +22,14 @@ class MenuTabs:
     }
     paths_reverse = {v: k for k, v in paths.items()}
 
+    display_labels = {
+        examples: "Examples",
+        history: "History",
+        saved: "Saved Runs",
+        run_as_api: "API",
+        integrations: "Integrations",
+    }
+
 
 def page_tabs(*, tabs, key=None):
     selected_menu = option_menu(