Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Naming] review demo projects names #65

Open
anton-karlovskiy opened this issue Oct 22, 2019 · 3 comments
Open

[Naming] review demo projects names #65

anton-karlovskiy opened this issue Oct 22, 2019 · 3 comments

Comments

@anton-karlovskiy
Copy link
Contributor

anton-karlovskiy commented Oct 22, 2019 •
edited
Loading

@addyosmani
I think device-class aware loading should be renamed to device-class aware code-splitting.
I think we might need to rename like resource loading, code-splitting, data-fetching. That is, just loading → resource loading since I think it sounds like loading covers more range including resource loading.

cra-memory-considerate-loading -> cra-memory-considerate-code-splitting or cra-memory-considerate-resource-loading because both mode are used here.

FYI: I found this issue while writing Recipes section in hooks/README.
@anton-karlovskiy anton-karlovskiy mentioned this issue Oct 22, 2019
Merged
@addyosmani
Copy link
Collaborator

This idea sgtm. Let's tackle after we land the README changes?

@anton-karlovskiy
Copy link
Contributor Author

@addyosmani
Yes for sure. No problem.

This was referenced Oct 24, 2019
Merged
Closed
@anton-karlovskiy
Copy link
Contributor Author

For keeping instructions:
#82 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@addyosmani @anton-karlovskiy