Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded support for GDPR banner acceptance feature #810

Open
5 tasks
Dbrown910 opened this issue Aug 20, 2024 · 3 comments · Fixed by #823
Open
5 tasks

Expanded support for GDPR banner acceptance feature #810

Dbrown910 opened this issue Aug 20, 2024 · 3 comments · Fixed by #823
Assignees
Milestone

Comments

@Dbrown910
Copy link

Dbrown910 commented Aug 20, 2024

Feature Request

Description:
PSAT CLI's current search for Cookie Consent banner buttons restricted to three specific English words (“accept”,”allow”, “agree”) potentially missing buttons with different phrasing or in other languages.

Motivation:
Some sites, particularly ones in non English languages, or ones that use different verbiage than the 3 currently accepted words prevent the GDPR banner from being accepted automatically during analysis. To cover as many use cases as we have discovered so far, a subset of the Google team will work to enhance this feature. This effort will be led by [email protected]

User Story:
As a PSAT CLI power user, I want comprehensive GDPR banner acceptance so that the analysis captures and reports on 3P cookies that are being blocked for technical reasons and not just because the user has not accepted them.

Acceptance Criteria:

  • Adding language options that are not captured currently (ex. "OK”, “Accepter”, etc)
  • Add all the options to a static array and check if GDPR's acceptance button value exists in the array
  • A / B test the feature using the _-i _ flag for toggling automation – should see more cookies with the feature on.
  • Verify if the isButtonForAccept variable returns true for GDPR banners on sites where it currently does not, such as Otto.de and lemonde.fr
  • [New] Add an option for users to provide a .json file as an argument with specific selectors they would like to be clicked when analyzing the site

Additional Information:
Example screenshots:
Screenshot 2024-08-19 at 8 37 56 PM
Screenshot 2024-08-19 at 8 38 27 PM

@Dbrown910 Dbrown910 changed the title Add non English support for GDPR banner acceptance Add additional language support for GDPR banner acceptance feature Aug 20, 2024
@amedina
Copy link
Collaborator

amedina commented Aug 20, 2024

Thanks for the feature request @Dbrown910. An enhancement along these lines have been included into our priorities for an upcoming release. Thanks also for the suggestions on plausible things to consider. Will keep FR request open while we proceed with the implementation.

@maitreyie-chavan maitreyie-chavan added this to the v1.0 milestone Aug 20, 2024
@amedina amedina changed the title Add additional language support for GDPR banner acceptance feature Expanded support for GDPR banner acceptance feature Aug 20, 2024
@tsunoyu
Copy link
Contributor

tsunoyu commented Aug 21, 2024

Hi,

Thank you for looking into this.
Adding another examples where "ok" is used to accept the cookie consent button.

image

@maitreyie-chavan maitreyie-chavan moved this from Todo to In Progress in PS Analysis Tool Aug 26, 2024
@maitreyie-chavan maitreyie-chavan modified the milestones: v1.0, v0.11 Aug 27, 2024
@amovar18 amovar18 linked a pull request Sep 2, 2024 that will close this issue
4 tasks
@maitreyie-chavan maitreyie-chavan moved this from In Progress to Under Review in PS Analysis Tool Sep 2, 2024
@maitreyie-chavan maitreyie-chavan moved this from Under Review to Release Ready in PS Analysis Tool Sep 9, 2024
@gagan0123
Copy link
Collaborator

Hi @Dbrown910,

Thanks for the feature request! We are focusing on flexibility over a fixed solution.

PSAT CLI now supports custom GDPR acceptance using a .json file with specific selectors (recently released in v0.11.0), adaptable to any language (documentation). This offers precise control over GDPR acceptance logic for accurate analysis.

Please try it out and share your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants