Modify row-filters as #171

GoogleCloudPlatform · May 16, 2022 · e5c9c9c · e5c9c9c
1 parent f8f741c
commit e5c9c9c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/configs/row_filters/row-filters.yml b/configs/row_filters/row-filters.yml
@@ -18,5 +18,7 @@ row_filters:
       True
 
   DATA_TYPE_EMAIL:
+    params: |-
+      column
     filter_sql_expr: |-
-      contact_type = 'email'
+      $column = 'email'
diff --git a/configs/rule_bindings/team-1-rule-bindings.yml b/configs/rule_bindings/team-1-rule-bindings.yml
@@ -16,6 +16,7 @@ rule_bindings:
   T1_DQ_1_VALUE_NOT_NULL:
     entity_id: TEST_TABLE
     column_id: VALUE
-    row_filter_id: NONE
+    row_filter_ids:
+      - NONE
     rule_ids:
       - NOT_NULL_SIMPLE
diff --git a/configs/rule_bindings/team-2-rule-bindings.yml b/configs/rule_bindings/team-2-rule-bindings.yml
@@ -16,7 +16,9 @@ rule_bindings:
   T2_DQ_1_EMAIL:
     entity_id: TEST_TABLE
     column_id: VALUE
-    row_filter_id: DATA_TYPE_EMAIL
+    row_filter_ids:
+      - DATA_TYPE_EMAIL:
+          column: "contact_type"
     rule_ids:
       - NOT_NULL_SIMPLE
       - REGEX_VALID_EMAIL

diff --git a/configs/rule_bindings/team-3-rule-bindings.yml b/configs/rule_bindings/team-3-rule-bindings.yml
@@ -16,7 +16,9 @@ rule_bindings:
   T3_DQ_1_EMAIL_DUPLICATE:
     entity_id: TEST_TABLE
     column_id: VALUE
-    row_filter_id: DATA_TYPE_EMAIL
+    row_filter_ids:
+      - DATA_TYPE_EMAIL:
+          column: "contact_type"
     rule_ids:
       - NO_DUPLICATES_IN_COLUMN_GROUPS:
           column_names: "contact_type,value"