Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more default rule types #2

Open
thinhha opened this issue Apr 3, 2021 · 3 comments
Open

add more default rule types #2

thinhha opened this issue Apr 3, 2021 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@thinhha
Copy link
Contributor

thinhha commented Apr 3, 2021

We should be able to implement all of dbt's schema tests as CUSTOM_SQL_STATEMENT. There may be other rules we can implement from https://docs.greatexpectations.io/en/latest/reference/glossary_of_expectations.html#dataset.

We should consider how to allow rules that reference multiple tables using references to tables (with overrides). The current alternative is to parameterize the table names.

It it make sense we may want to implement the rule directly in https://github.com/GoogleCloudPlatform/cloud-data-quality/blob/main/clouddq/classes/rule_type.py

@thinhha thinhha added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 3, 2021
@thinhha
Copy link
Contributor Author

thinhha commented Jun 14, 2021

more default rule types we can add:
https://github.com/calogica/dbt-expectations

@bogo96
Copy link

bogo96 commented Apr 28, 2022

hi, i wonder if you have plan to supporting dbt-expectations? Such as using dbt-expectations rules inside configs/rules.
If not, can i make issue with details and go for it?

@thinhha
Copy link
Contributor Author

thinhha commented May 2, 2022

Hi @bogo96 please go ahead! I suggest adding integrations tests like below however I'm happy to collaborate with you on this :)
https://github.com/GoogleCloudPlatform/cloud-data-quality/blob/main/tests/integration/test_advanced_dq_rules.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants