Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: don't overwrite builtin max function #2321

Merged
merged 1 commit into from
Nov 21, 2024
Merged

chore: don't overwrite builtin max function #2321

merged 1 commit into from
Nov 21, 2024

Conversation

jackwotherspoon
Copy link
Collaborator

Rename max vars.

New golangci-lint check now does not allow variable names to be max or min due to built-ins.

@jackwotherspoon jackwotherspoon self-assigned this Nov 20, 2024
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner November 20, 2024 20:25
@jackwotherspoon jackwotherspoon merged commit 0ac96ea into main Nov 21, 2024
13 checks passed
@jackwotherspoon jackwotherspoon deleted the max-var branch November 21, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hessjcg hessjcg hessjcg approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackwotherspoon @hessjcg