Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Ruff for lint job #1226

Open
jackwotherspoon opened this issue Jan 20, 2025 · 1 comment
Open

Use Ruff for lint job #1226

jackwotherspoon opened this issue Jan 20, 2025 · 1 comment
Assignees
@jackwotherspoon
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@jackwotherspoon
Copy link
Collaborator

Ruff is 10-100x quicker for linting and offers drop in replacements for flake8, isort, and black.

Switch to using Ruff for our nox sessions (lint job).

This is really easy to do once we switch to using a pyproject.toml file for our package.

So we should have this depend on #989 as a pre-req
@jackwotherspoon jackwotherspoon added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jan 20, 2025
@jackwotherspoon jackwotherspoon self-assigned this Jan 20, 2025
@enocom
Copy link
Member

enocom commented Jan 21, 2025

We should probably match this in AlloyDB.

cc @rhatgadkar-goog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackwotherspoon jackwotherspoon

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enocom @jackwotherspoon