Protobuf extension (#317)

* Build protobuf from pecl

* build protobuf package from github release until published on pecl

* protobuf 3.3.2 was pushed to pecl. download from there

* Enable extension installer for protobufs

* need to install the protobuf package

deb-package-builder/build.sh

@@ -40,7 +40,7 @@ PHP_VERSIONS=${1}
 EXTENSIONS=${2}
 if [ -z "$EXTENSIONS" ]; then
     # Explicitly declaring because some extenions depend on others (pq depends on raphf)
-    EXTENSIONS="apcu,apcu_bc,ev,event,grpc,imagick,jsonc,mailparse,memcache,memcached,mongodb,oauth,phalcon,raphf,pq,rdkafka,redis,suhosin,libuv,cassandra-cpp-driver,cassandra"
+    EXTENSIONS="apcu,apcu_bc,ev,event,grpc,imagick,jsonc,mailparse,memcache,memcached,mongodb,oauth,phalcon,protobuf,raphf,pq,rdkafka,redis,suhosin,libuv,cassandra-cpp-driver,cassandra"
 fi
 
 

deb-package-builder/extensions/protobuf/build.sh

@@ -0,0 +1,13 @@
+#!/bin/bash
+
+set -ex
+
+source ${DEB_BUILDER_DIR}/extensions/functions.sh
+
+echo "Building protobuf for gcp-php${SHORT_VERSION}"
+
+PNAME="gcp-php${SHORT_VERSION}-protobuf"
+
+# Download the source
+download_from_pecl protobuf
+build_package protobuf

deb-package-builder/extensions/protobuf/debian/compat

@@ -0,0 +1 @@
+9

deb-package-builder/extensions/protobuf/debian/control.in

@@ -0,0 +1,12 @@
+Source: gcp-php${SHORT_VERSION}-protobuf
+Section: php
+Priority: optional
+Maintainer: Jeff Ching <[email protected]>
+Build-Depends: debhelper (>= 9), gcp-php${SHORT_VERSION}
+Standards-Version: 3.9.5
+Homepage: http://pecl.php.net/package/protobuf
+
+Package: gcp-php${SHORT_VERSION}-protobuf
+Architecture: any
+Depends: libc6 (>= 2.4), gcp-php${SHORT_VERSION}
+Description: protobuf extension module for gcp-php${SHORT_VERSION}

deb-package-builder/extensions/protobuf/debian/copyright

@@ -0,0 +1,37 @@
+Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: protobuf
+Upstream-Contact: Stanley Cheung <[email protected]>
+Source: http://pecl.php.net/package/protobuf/
+
+Files: *
+Copyright: 2015, Google Inc.
+License: BSD
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions are
+ met:
+ .
+    * Redistributions of source code must retain the above copyright
+      notice, this list of conditions and the following disclaimer.
+    * Redistributions in binary form must reproduce the above
+      copyright notice, this list of conditions and the following disclaimer
+      in the documentation and/or other materials provided with the
+      distribution.
+    * Neither the name of Google Inc. nor the names of its
+ contributors may be used to endorse or promote products derived from
+ this software without specific prior written permission.
+ .
+ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+Files: debian/*
+Copyright: 2017 Google, Inc.
+License: Apache-2.0

deb-package-builder/extensions/protobuf/debian/ext-protobuf.ini

@@ -0,0 +1 @@
+extension=protobuf.so

deb-package-builder/extensions/protobuf/debian/gcp-php-protobuf.install.in

@@ -0,0 +1 @@
+debian/ext-protobuf.ini opt/php${SHORT_VERSION}/lib/ext.available

deb-package-builder/extensions/protobuf/debian/rules.in

@@ -0,0 +1,14 @@
+#!/usr/bin/make -f
+
+%:
+	dh $@
+
+override_dh_auto_configure:
+	phpize && \
+	./configure
+
+override_dh_auto_test:
+
+override_dh_auto_install:
+	INSTALL_ROOT=$(CURDIR)/debian/gcp-php${SHORT_VERSION}-protobuf \
+		dh_auto_install

php-base/build-scripts/install_extensions.php

@@ -46,6 +46,7 @@ class InstallExtensions
         'oauth',
         'phalcon',
         'pq',
+        'protobuf',
         'raphf',
         'rdkafka',
         'redis'

php-base/build-scripts/install_php56.sh

@@ -34,6 +34,7 @@ apt-get install -y \
         gcp-php56-oauth \
         gcp-php56-phalcon \
         gcp-php56-pq \
+        gcp-php56-protobuf \
         gcp-php56-rdkafka \
         gcp-php56-redis \
         gcp-php56-suhosin \

php-base/build-scripts/install_php70.sh

@@ -33,6 +33,7 @@ apt-get install -y \
         gcp-php70-oauth \
         gcp-php70-phalcon \
         gcp-php70-pq \
+        gcp-php70-protobuf \
         gcp-php70-rdkafka \
         gcp-php70-redis \
         --no-install-recommends

php-base/build-scripts/install_php71.sh

@@ -32,6 +32,7 @@ apt-get install -y \
         gcp-php71-mongodb \
         gcp-php71-oauth \
         gcp-php71-pq \
+        gcp-php71-protobuf \
         gcp-php71-rdkafka \
         gcp-php71-redis \
         --no-install-recommends

testapps/php56_extensions/composer.json

@@ -27,6 +27,7 @@
         "ext-raphf": "*",
         "ext-pq": "*",
         "ext-rdkafka": "*",
-        "ext-cassandra": "*"
+        "ext-cassandra": "*",
+        "ext-protobuf": "*"
     }
 }

testapps/php56_extensions/tests/ProtobufTest.php

@@ -0,0 +1,26 @@
+<?php
+/**
+ * Copyright 2017 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+class ProtobufTest extends \PHPUnit_Framework_TestCase
+{
+    private $success = false;
+
+    public function testExtensionLoaded()
+    {
+        $this->assertTrue(extension_loaded('protobuf'));
+    }
+}

testapps/php70_extensions/composer.json

@@ -26,6 +26,7 @@
         "ext-raphf": "*",
         "ext-pq": "*",
         "ext-rdkafka": "*",
-        "ext-cassandra": "*"
+        "ext-cassandra": "*",
+        "ext-protobuf": "*"
     }
 }

testapps/php70_extensions/tests/ProtobufTest.php

@@ -0,0 +1,26 @@
+<?php
+/**
+ * Copyright 2017 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+class ProtobufTest extends \PHPUnit_Framework_TestCase
+{
+    private $success = false;
+
+    public function testExtensionLoaded()
+    {
+        $this->assertTrue(extension_loaded('protobuf'));
+    }
+}

testapps/php71_extensions/composer.json

@@ -25,6 +25,7 @@
         "ext-raphf": "*",
         "ext-pq": "*",
         "ext-rdkafka": "*",
-        "ext-cassandra": "*"
+        "ext-cassandra": "*",
+        "ext-protobuf": "*"
     }
 }

testapps/php71_extensions/tests/ProtobufTest.php

@@ -0,0 +1,26 @@
+<?php
+/**
+ * Copyright 2017 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+class ProtobufTest extends \PHPUnit_Framework_TestCase
+{
+    private $success = false;
+
+    public function testExtensionLoaded()
+    {
+        $this->assertTrue(extension_loaded('protobuf'));
+    }
+}