Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - Correct cleanup command to store and use migration project id from metadata db #808

Open
darshan-sj opened this issue Apr 4, 2024 · 0 comments

Comments

@darshan-sj
Copy link
Collaborator

Support for separate migration project id and spanner project id was added in this PR

In the above PR, for cleanup, migration project id is directly taken from gcloud config. The proper implementation would be to store the migration project id in the metadata DB while initiating the migration. and then use the stored migration project id to cleanup the migration resources.

Pending tasks:

  • metadata db schema changes to store migration project id
  • Changes to store migration project id.
  • Changes in cleanup command to use the migration project id from the metadata db.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant