End of table (e.g. </tr></table>) does not get generated.

[iliatimofeev]

import CommonMarkExtensions.tables
display(HTML( CommonMarkExtensions.tables.commonmark("""
|  Col     | Header 2 |
| -------- | -------- |
| Cells    | **can**  |
| `have`   | inlines. |

# Second table

|  Col2    | Header 3 |
| -------- | -------- |
| Cells    | **can**  |
| `have`   | inlines. |

""") ))

Col	Header 2
Cells	can
have	inlines.
# Second table
Col2	Header 3
Cells	can
have	inlines.

[gregelin]

@iliatimofeev Thanks. I've verified the issue.

[hughdavenport]

Workaround for this, until PR#7 gets merged.

import commonmark_extensions.tables
import commonmark.blocks

def check_commonmark_tables_bug3():

    class TableWaitingForBug3(commonmark_extensions.tables.Table):
        @staticmethod
        def continue_(parser=None, container=None):
            ln = parser.current_line
            if not parser.indented and commonmark.blocks.peek(ln, parser.next_nonspace) == "|":
                parser.advance_next_nonspace()
                parser.advance_offset(1, False)
            elif not parser.indented and commonmark.blocks.peek(ln, parser.next_nonspace) not in ("", ">", "`", None):
                pass
            else:
                return 1
            return 0

    parser = commonmark_extensions.tables.ParserWithTables()
    renderer = commonmark_extensions.tables.RendererWithTables()
    example_202 = """| abc | def |
| --- | --- |
| bar | baz |
bar

bar"""
    example_202_expected = """<table>
<thead>
<tr>
<th>abc</th>
<th>def</th>
</tr>
</thead>
<tbody>
<tr>
<td>bar</td>
<td>baz</td>
</tr>
<tr>
<td>bar</td>
<td></td>
</tr>
</tbody>
</table>

<p>bar</p>"""
    if renderer.render(parser.parse(example_202)) != example_202_expected:
        commonmark.blocks.Table = TableWaitingForBug3

    return commonmark.blocks.Table

I have the above saved in monkey_patches.py, then in my main script I have:

import commonmark
import monkey_patches
commonmark.blocks.Table = monkey_patches.check_commonmark_tables_bug3()

This is basically grabbing the patched file from d5b8845, and using that if the test for this bug fails.

Hopefully someone finds this useful in their codebase :)

[hughdavenport]

Workaround if you are now using Python3.9 with commonmark 0.9.1 until #7 and #8 is merged. This is mostly the same as above, but checks whether the parser has a blocks dict (this is introduced in commonmark 0.9.1) and ensures that it is using the correct table class.

import commonmark_extensions.tables
import commonmark.blocks

def check_commonmark_tables_bug3():

    class TableWaitingForBug3(commonmark_extensions.tables.Table):
        @staticmethod
        def continue_(parser=None, container=None):
            ln = parser.current_line
            if not parser.indented and commonmark.blocks.peek(ln, parser.next_nonspace) == "|":
                parser.advance_next_nonspace()
                parser.advance_offset(1, False)
            elif not parser.indented and commonmark.blocks.peek(ln, parser.next_nonspace) not in ("", ">", "`", None):
                pass
            else:
                return 1
            return 0

    parser = commonmark_extensions.tables.ParserWithTables()
    bug4 = hasattr(parser. 'blocks') and 'table' not in parser.blocks
    if bug4:
        parser.blocks['table'] = commonmark.blocks.Table
    renderer = commonmark_extensions.tables.RendererWithTables()
    example_202 = """| abc | def |
| --- | --- |
| bar | baz |
bar

bar"""
    example_202_expected = """<table>
<thead>
<tr>
<th>abc</th>
<th>def</th>
</tr>
</thead>
<tbody>
<tr>
<td>bar</td>
<td>baz</td>
</tr>
<tr>
<td>bar</td>
<td></td>
</tr>
</tbody>
</table>

<p>bar</p>"""
    if renderer.render(parser.parse(example_202)) != example_202_expected:
        commonmark.blocks.Table = TableWaitingForBug3
        if bug4:
            parser.blocks['table'] = commonmark.blocks.Table

    return commonmark.blocks.Table