Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing #6

Open
hughdavenport opened this issue Nov 25, 2020 · 1 comment · May be fixed by #7
Open

Tests failing #6

hughdavenport opened this issue Nov 25, 2020 · 1 comment · May be fixed by #7

Comments

@hughdavenport
Copy link
Contributor

PR incoming with fixes.

Tests that are failing with links to the GFM spec: test_break2, test_cols_need_not_match, and test_header_cells_count_matches_delimiter_row.

Versions:

commonmark           0.8.1
commonmarkextensions 0.0.5

Output of python3 tests.py.

..FF.F.....
======================================================================
FAIL: test_break2 (__main__.GithubFlavoredTablesTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests.py", line 120, in test_break2
    self.assertRender(
  File "tests.py", line 20, in assertRender
    self.assertEqual(html, expected)
AssertionError: '<tab[121 chars]<td>bar</td>\n<td></td>\n</tr>\n</tbody>\n</table>' != '<tab[121 chars]<td>bar</td>\n<td></td>\n</tr>\n</tbody>\n</table>\n<p>bar</p>'
  <table>
  <thead>
  <tr>
  <th>abc</th>
  <th>def</th>
  </tr>
  </thead>
  <tbody>
  <tr>
  <td>bar</td>
  <td>baz</td>
  </tr>
  <tr>
  <td>bar</td>
  <td></td>
  </tr>
  </tbody>
- </table>+ </table>
?         +
+ <p>bar</p>

======================================================================
FAIL: test_cols_need_not_match (__main__.GithubFlavoredTablesTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests.py", line 159, in test_cols_need_not_match
    self.assertRender(
  File "tests.py", line 20, in assertRender
    self.assertEqual(html, expected)
AssertionError: '<tab[123 chars]ar</td>\n<td>baz</td>\n<td>boo</td>\n</tr>\n</tbody>\n</table>' != '<tab[123 chars]ar</td>\n<td>baz</td>\n</tr>\n</tbody>\n</table>'
  <table>
  <thead>
  <tr>
  <th>abc</th>
  <th>def</th>
  </tr>
  </thead>
  <tbody>
  <tr>
  <td>bar</td>
  <td></td>
  </tr>
  <tr>
  <td>bar</td>
  <td>baz</td>
- <td>boo</td>
  </tr>
  </tbody>
  </table>

======================================================================
FAIL: test_header_cells_count_matches_delimiter_row (__main__.GithubFlavoredTablesTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests.py", line 148, in test_header_cells_count_matches_delimiter_row
    self.assertRender(
  File "tests.py", line 20, in assertRender
    self.assertEqual(html, expected)
AssertionError: '<table>\n<thead>\n<tr>\n<th>abc</th>\n<th>[88 chars]ble>' != '<p>| abc | def |\n| --- |\n| bar |</p>'
+ <p>| abc | def |
+ | --- |
+ | bar |</p>- <table>
- <thead>
- <tr>
- <th>abc</th>
- <th>def</th>
- </tr>
- </thead>
- <tbody>
- <tr>
- <td>bar</td>
- <td></td>
- </tr>
- </tbody>
- </table>

----------------------------------------------------------------------
Ran 11 tests in 0.050s

FAILED (failures=3)
@hughdavenport hughdavenport linked a pull request Nov 26, 2020 that will close this issue
@hughdavenport
Copy link
Contributor Author

My latest PR (#11) may have broken this. Have not tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant