Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound problem #2115

Closed
marconatale00 opened this issue Feb 12, 2025 · 16 comments · Fixed by #2124
Closed

Sound problem #2115

marconatale00 opened this issue Feb 12, 2025 · 16 comments · Fixed by #2124
Labels
help wanted Extra attention is needed

Comments

@marconatale00
Copy link

Good evening, I am opening a report regarding a problem that many have reported to me and which I am reporting here, there is a problem at the sound level that the sound is more metallic, almost electronic coming out of the amplifiers which is not the case with Hauptwerk, a comparison was made with Piotr Grambowski's Friesach organ which no longer produces sets because the sound quality between the two software has become too significant there is a public post on the organ manufacturer's website. I will also try to collect further information to be able to focus attention on the problem and a detailed report should also arrive in a few days/weeks

@MStraeten
Copy link

please give more infos on the system configurations where this issue occurs.
Haven’t recognized such behaviour on my macOS machine …

@oleg68
Copy link
Contributor

oleg68 commented Feb 14, 2025 via email

@larspalo
Copy link
Contributor

@oleg68 I see no problem changing the defaults to to 48 kHz and 512 samples/buffer and polyphase interpolation. But in truth, that likely won't solve every possible issue an user could encounter either.

In my experience the settings should more or less always be set to what the original samples of a sample set are to get the best performance. But the individual experience might of course be different (depending on their hardware and OS).

With regards to the linear and polyphase interpolation it's more a question on what you want to prioritize. For me, it seems that polyphase gives better results to high frequencies and linear to low frequencies whenever interpolation is necessary. It might make sense to change the default to polyphase, but that won't currently be the optimal for every user either...

@oleg68
Copy link
Contributor

oleg68 commented Feb 15, 2025

@rousseldenis what is your opinion about changing the defaults?

@oleg68
Copy link
Contributor

oleg68 commented Feb 15, 2025

In my experience the settings should more or less always be set to what the original samples of a sample set are to get the best performance.

I agree with you. But most of modern sample sets have 48000 bps, so the new default will be better in most cases.

With regards to the linear and polyphase interpolation it's more a question on what you want to prioritize. For me, it seems that polyphase gives better results to high frequencies and linear to low frequencies whenever interpolation is necessary. It might make sense to change the default to polyphase,

Linear interpolation adds additional harmonics starting with the second one when the polyphase - only with the eighth one. So the result of pholyphase is closer to the original sound. May be you like the "additional" harmonics for low frequencies, but adding more stops gives the same result.

but that won't currently be the optimal for every user either...

Unfortunately most of users expect the sound quality out of box and do not try to change settings. They do not ask the question "how to enchance sound quality?"; they just only complain about the bad sound and reject any interaction.

I understand that all users are different and always there will be ones that won't like the new defaults. So I'm talking on the probability and I think the defaults should be adequate for most users.

oleg68 added a commit to oleg68/GrandOrgue-official that referenced this issue Feb 15, 2025
…faults GrandOrgue#2115

- Changed default sample rate, samples per buffer and interpolation type to 48000, 512 and Polyphase
- Increased the maximum samples per buffer to 2048
- Increased the maximum supported sample rate to 192000
- Increased the maximum number of user-defined temperaments to 999
@marconatale00
Copy link
Author

Thank you all for the support, a high-performance Windows 10 computer with 64 GB of RAM was used and no settings were touched either in GrandOrgue or in Hauptwerk. The composite was loaded in 24 bit at maximum quality. I'm waiting for someone to take stock of the problems encountered. Could you explain to me in detail how to change the Polyphase so we can do a test. I thank everyone again for the maximum support.

@oleg68
Copy link
Contributor

oleg68 commented Feb 16, 2025

@marconatale00 please go to File->Settings and post here the screenshots of the Options and Audio tabs.

@marconatale00
Copy link
Author

@oleg68

Image

Image

@oleg68
Copy link
Contributor

oleg68 commented Feb 17, 2025

@marconatale00 I see you have only 8GB of RAM installed instead 64 GB of RAM and only 4 CPU threads. It may be not sufficient for loading Friesach with a high quality, but let's try to do everything we can.

Please go to the Audio Tab, select "Device [50 ms selected]", click on "Change" and post the screenshot of the Device Selection dialog here.

@marconatale00
Copy link
Author

@oleg68 I'm on an office PC, my PC dedicated to the organ has 128 GB of RAM installed, it's just to be able to understand what can be changed to have a setting like Hauptwerk

@oleg68
Copy link
Contributor

oleg68 commented Feb 17, 2025

to be able to understand what can be changed to have a setting like Hauptwerk

  • Audio Tab: Select another device instead of the default one. The best option is to use an ASIO device.
  • Audio Tab: Frequenza di campionamento: change to 48000
  • Audio Tab: Campioni per buffer: reduce to 512 or 256. If you have ASIO, you can try 128 or even 64.
  • Options Tab: Interpolazione: Change to Polyphase.

@rousseldenis
Copy link
Contributor

rousseldenis commented Feb 17, 2025

@marconatale00 @oleg68 I've remarked that too on new installs of GrandOrgue:

  • The audio groups duplicate right and left channels.

@marconatale00 So, you need to remove one audio group per channel.

@rousseldenis
Copy link
Contributor

@rousseldenis what is your opinion about changing the defaults?

Yes, of course.

IMHO, most of new configuration are able to support higher cpu processing

@rousseldenis
Copy link
Contributor

@oleg68 I'm on an office PC, my PC dedicated to the organ has 128 GB of RAM installed, it's just to be able to understand what can be changed to have a setting like Hauptwerk

Change the memory to something approaching your configuration:

Image

Note that GrandOrgue, per default, use your system memory limits to configure that field.

@rousseldenis rousseldenis added the help wanted Extra attention is needed label Feb 17, 2025
oleg68 added a commit to oleg68/GrandOrgue-official that referenced this issue Feb 17, 2025
…faults GrandOrgue#2115

- Changed default sample rate, samples per buffer and interpolation type to 48000, 512 and Polyphase
- Increased the maximum samples per buffer to 2048
- Increased the maximum supported sample rate to 192000
- Increased the maximum number of user-defined temperaments to 999
oleg68 added a commit to oleg68/GrandOrgue-official that referenced this issue Feb 17, 2025
@oleg68
Copy link
Contributor

oleg68 commented Feb 17, 2025

  • The audio groups duplicate right and left channels.

Thank you, @rousseldenis . I think you've found the main reason of the bad sound.

I submitted #2124 that fixes this problem.

@oleg68
Copy link
Contributor

oleg68 commented Feb 17, 2025

@rousseldenis Seems Denis found the main issue:

For fixing it you have to:

  • Go to the Audio Tab
  • Change the level of the sinistra in Canale 1 to 0
  • Delete the destra from Canale 1
  • Delete the sinistra from Canale 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
5 participants