Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use actions/upload-artifact@v4 and actions/download-artifact@v4 #924

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

roi-granulate
Copy link
Contributor

@roi-granulate roi-granulate commented Sep 22, 2024

Description

GH have deprecated actions/upload-artifact: v2 and actions/download-artifact: v2 (further reading)
This makes our CI to fail. see here

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots

Checklist:

  • I have read the CONTRIBUTING document.
  • I have updated the relevant documentation.
  • I have added tests for new logic.

Jongy
Jongy previously approved these changes Sep 22, 2024
d3dave
d3dave previously requested changes Sep 22, 2024
Copy link
Contributor

@d3dave d3dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Jongy Jongy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can merge if passes. make sure to fix PR & commit title.

@roi-granulate roi-granulate changed the title CI: use actions/upload-artifact@v3 CI: use actions/upload-artifact@v4 and actions/download-artifact@v4 Sep 23, 2024
@roi-granulate roi-granulate marked this pull request as ready for review September 23, 2024 05:49
@roi-granulate roi-granulate merged commit 03da7f2 into master Sep 23, 2024
28 checks passed
@roi-granulate roi-granulate deleted the fix-ci branch September 23, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants