Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade codemirror to version 6 #5585

Closed
wants to merge 2 commits into from
Closed

Conversation

xQwexx
Copy link
Contributor

@xQwexx xQwexx commented Dec 27, 2023

I want to create an trait which takes a js function as input, but for that I wanted to use readonly-ranges extension which only available at version 6

I needed to upgrade codemirror js and I think this would be nice if we could merge into this as a separate pr.

@artf
Copy link
Member

artf commented Jan 11, 2024

Sorry @xQwexx I'd definitely like to upgrade/remove the codemirror dependency here but can't for the same reason explained here so please for now keep these changes in your application, one day we'll make UI components better

@artf artf closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants