Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Include better version numbers in github built artifacts. #2539

Closed
tomprince opened this issue Dec 13, 2024 · 1 comment
Closed

[build] Include better version numbers in github built artifacts. #2539

tomprince opened this issue Dec 13, 2024 · 1 comment
Labels
type: feature New feature or request

Comments

@tomprince
Copy link
Contributor

Cross-mod Integration

No response

Feature Description

  • I was asked to test Fix AIOOBE due to recipe running too fast #2535. When I downloaded the artifacts from it, they had version 1.5.5. It should have some indication that those artifacts are not from a release. Bonus points if the version includes the PR number and commit (at least the short form).
  • I have been running various incarnations of https://github.com/GregTechCEu/GregTech-Modern/releases/tag/latest-1.20.1. The version that (currently) reports as is 1.5.5-SNAPSHOT. However, as that tag changes, and I've run multiple versions of it, it can be hard to identify what precise version I'm running. The version should include some indication of what specific snapshot it is. The tag includes a commit date, so that seems sensible to include in the version number. It could also be helpful to include the commit as well.
    Since that tag changes, it might also be helpful to create a tag for snapshots that don't change, so people can easily go back and see what a specific snapshot is (and possibly make it easier to revert to an earlier snapshot if there are issues with a later one). Extra bonus points for using identical bonus points for using the same artifacts for the stable and latest-1.20.1 tags.
@jtuc
Copy link
Contributor

jtuc commented Dec 20, 2024

Resolved by #2588?

@screret screret closed this as completed Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants