Include git hash in snapshot build versions #2547
Conversation
Also build PRs as snapshots, and rename the printVersion task to printModVersion (Annoyingly, the palantir git-version plugin adds its own task named printVersion)
jtuc
changed the title
|
Ah, good point. I thought this would just be a quick tweak, but I should probably leave it to someone with the permissions/keys/etc to test the workflows. |
|
If you want to reattempt it, just have the workflows rename all the JARs before uploading instead of doing it in gradle. It won't mess with maven. You can ping me in Discord if you want help. |
|
Just renaming the JARs on PRs would probably be fine, but I did really like seeing the hash in-game via mods.toml. Maybe I'll revisit it, but I closed this PR as I don't really think it's a huge priority either. |
I would definitely prefer if the mods were detected as having the additional version metadata by things like Prism. |
What
Include git hash in snapshot builds, and build PRs as snapshots
Implementation Details
This uses the palantir git-version plugin, which annoyingly has a hardcoded printVersion task. I've renamed GTM's printVersion to printModVersion to avoid the clash, and adjusted github actions to compensate.
Outcome
Fixes #2539 (although that issue does also ask for Github PR numbers etc, I think the commithash is the most important info.)
Additional Information
Potential Compatibility Issues
I think the "Sync Github Folder" action will only take the action changes and not the gradle changes - so this would probably need to be merged to 1.21 manually.