Refactor DataStick item and associated interaction interface #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced edge cases with implementations of IDataStickInteractable. IDataStickInteractable no longer implements IInteractedMachine.
krossgg
requested changes
Dec 19, 2024
src/main/java/com/gregtechceu/gtceu/common/item/DataItemBehavior.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/integration/ae2/machine/MEPatternBufferPartMachine.java
Outdated
Show resolved
Hide resolved
|
uh? |
|
deleted the wrong branch |
krossgg
requested changes
Dec 20, 2024
src/main/java/com/gregtechceu/gtceu/common/item/DataItemBehavior.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/integration/ae2/machine/MEPatternBufferPartMachine.java
Show resolved
Hide resolved
krossgg
requested changes
Dec 20, 2024
src/main/java/com/gregtechceu/gtceu/common/item/DataItemBehavior.java
Outdated
Show resolved
Hide resolved
...ain/java/com/gregtechceu/gtceu/common/item/tool/behavior/MetaMachineConfigCopyBehaviour.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/integration/ae2/machine/MEInputBusPartMachine.java
Outdated
Show resolved
Hide resolved
krossgg
approved these changes
Dec 20, 2024
omergunr100
added a commit
to omergunr100/GregTech-Modern
that referenced
this pull request
Dec 25, 2024
screret
pushed a commit
that referenced
this pull request
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Data stick now copies on sneak + right click and pastes on right click.
Cleanup.
Implementation Details
Moved from
useOntoonItemUseFirstto be able to use shift clicking.Machines that implement
IDataStickInteractableno longer need to implementIInteractedMachine.Removed edge cases from the data stick logic by implementing
IDataStickInteractable.Additionally
Fixes #2556
Potential Compatibility Issues
Any addon machines that used to implement
IDataStickInteractablewill need to be refactored to match the new method signatures. (although addon machines should probably be handled by the memory card for most cases)