chore: shutdown on test

GreptimeTeam · Jan 8, 2024 · baede06 · baede06
1 parent 461588a
commit baede06
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 3 deletions.
diff --git a/ingester-example/src/main/java/io/greptime/StreamWritePOJOsQuickStart.java b/ingester-example/src/main/java/io/greptime/StreamWritePOJOsQuickStart.java
@@ -77,5 +77,8 @@ public static void main(String[] args) throws ExecutionException, InterruptedExc
         WriteOk result = future.get();
 
         LOG.info("Write result: {}", result);
+
+        // Shutdown the client when application exits.
+        greptimeDB.shutdownGracefully();
     }
 }
diff --git a/ingester-example/src/main/java/io/greptime/StreamWriteQuickStart.java b/ingester-example/src/main/java/io/greptime/StreamWriteQuickStart.java
@@ -98,5 +98,8 @@ public static void main(String[] args) throws ExecutionException, InterruptedExc
         WriteOk result = future.get();
 
         LOG.info("Write result: {}", result);
+
+        // Shutdown the client when application exits.
+        greptimeDB.shutdownGracefully();
     }
 }
diff --git a/ingester-example/src/main/java/io/greptime/WritePOJOsQuickStart.java b/ingester-example/src/main/java/io/greptime/WritePOJOsQuickStart.java
@@ -86,5 +86,8 @@ public static void main(String[] args) throws ExecutionException, InterruptedExc
         } else {
             LOG.error("Failed to delete: {}", result.getErr());
         }
+
+        // Shutdown the client when application exits.
+        greptimeDB.shutdownGracefully();
     }
 }
diff --git a/ingester-example/src/main/java/io/greptime/WriteQuickStart.java b/ingester-example/src/main/java/io/greptime/WriteQuickStart.java
@@ -109,5 +109,8 @@ public static void main(String[] args) throws ExecutionException, InterruptedExc
         } else {
             LOG.error("Failed to delete: {}", result.getErr());
         }
+
+        // Shutdown the client when application exits.
+        greptimeDB.shutdownGracefully();
     }
 }
diff --git a/ingester-protocol/src/main/java/io/greptime/Write.java b/ingester-protocol/src/main/java/io/greptime/Write.java
@@ -35,7 +35,7 @@ public interface Write {
      * @see #write(Collection, WriteOp, Context)
      */
     default CompletableFuture<Result<WriteOk, Err>> write(Table... tables) {
-        return write(Arrays.asList(tables), WriteOp.Insert, Context.newDefault());
+        return write(Arrays.asList(tables));
     }
 
     /**

diff --git a/ingester-protocol/src/main/java/io/greptime/WritePOJO.java b/ingester-protocol/src/main/java/io/greptime/WritePOJO.java
@@ -35,7 +35,7 @@ public interface WritePOJO {
      * @see #writePOJOs(Collection, WriteOp, Context)
      */
     default CompletableFuture<Result<WriteOk, Err>> writePOJOs(List<?>... pojos) {
-        return writePOJOs(Arrays.asList(pojos), WriteOp.Insert, Context.newDefault());
+        return writePOJOs(Arrays.asList(pojos));
     }
     /**
      * @see #writePOJOs(Collection, WriteOp, Context)

diff --git a/ingester-protocol/src/test/java/io/greptime/WriteClientTest.java b/ingester-protocol/src/test/java/io/greptime/WriteClientTest.java
@@ -105,7 +105,7 @@ public void testWriteSuccess() throws ExecutionException, InterruptedException {
         Mockito.when(this.routerClient.invoke(Mockito.eq(addr), Mockito.any(), Mockito.any())) //
                 .thenReturn(Util.completedCf(response));
 
-        Result<WriteOk, Err> res = this.writeClient.write(Collections.singleton(table)).get();
+        Result<WriteOk, Err> res = this.writeClient.write(table).get();
 
         Assert.assertTrue(res.isOk());
         Assert.assertEquals(3, res.getOk().getSuccess());