Skip to content

Commit

Permalink
chore: fix aws_lc check in CI
Browse files Browse the repository at this point in the history
  • Loading branch information
discord9 committed Dec 9, 2024
1 parent 19373d8 commit 05f8374
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/develop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -272,10 +272,14 @@ jobs:
- name: Check aws-lc-sys will not build
shell: bash
run: |
if cargo tree -i aws-lc-sys -e features | grep -q aws-lc-sys; then
tempfile=$(mktemp)
cargo tree -i aws-lc-sys -e features --target all &> $tempfile
if grep -q "aws-lc-sys" "$tempfile" && ! grep -q "package ID specification \`aws-lc-sys\` did not match any packages" "$tempfile"; then
# found `aws-lc-sys` in tree but not in error msg
echo "Found aws-lc-sys, which has compilation problems on older gcc versions. Please replace it with ring until its building experience improves."
exit 1
fi
rm $tempfile
- name: Build greptime bianry
shell: bash
# `cargo gc` will invoke `cargo build` with specified args
Expand Down
5 changes: 0 additions & 5 deletions src/servers/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,6 @@ tokio-test = "0.4"
[target.'cfg(unix)'.dev-dependencies]
pprof = { version = "0.13", features = ["criterion", "flamegraph"] }

[target.'cfg(windows)'.dependencies]
aws-lc-sys = { version = "0.21.0", features = [
"prebuilt-nasm",
] } # use prebuilt nasm on windows per https://github.com/aws/aws-lc-rs/blob/main/aws-lc-sys/README.md#use-of-prebuilt-nasm-objects

[build-dependencies]
common-version.workspace = true

Expand Down

0 comments on commit 05f8374

Please sign in to comment.