From b88a8ea52a9114430096d8e1d5f13aa049bb548e Mon Sep 17 00:00:00 2001 From: discord9 Date: Thu, 8 Aug 2024 14:33:10 +0800 Subject: [PATCH] chore: per review --- src/cmd/src/bin/greptime.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cmd/src/bin/greptime.rs b/src/cmd/src/bin/greptime.rs index c31f0339a1a0..5a599d0c0191 100644 --- a/src/cmd/src/bin/greptime.rs +++ b/src/cmd/src/bin/greptime.rs @@ -64,7 +64,7 @@ enum SubCommand { static ALLOC: tikv_jemallocator::Jemalloc = tikv_jemallocator::Jemalloc; fn main() -> Result<()> { - // Set the stack size to 8MB for the thread so it wouldn't crash on large stack usage in debug mode + // Set the stack size to 8MB for the thread so it wouldn't overflow on large stack usage in debug mode // see https://github.com/GreptimeTeam/greptimedb/pull/4317 // and https://github.com/rust-lang/rust/issues/34283 let builder = std::thread::Builder::new().name("main_spawn".to_string()); @@ -83,11 +83,11 @@ fn main() -> Result<()> { #[cfg(debug_assertions)] let builder = builder.thread_stack_size(8 * 1024 * 1024); - return builder + builder .enable_all() .build() .expect("Failed building the Runtime") - .block_on(body); + .block_on(body) } }) .context(SpawnThreadSnafu)?