Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the return type of RegionEngine::handle_request() #2784

Closed
waynexia opened this issue Nov 21, 2023 · 1 comment · Fixed by #2874
Closed

Change the return type of RegionEngine::handle_request() #2784

waynexia opened this issue Nov 21, 2023 · 1 comment · Fixed by #2874
Assignees
Labels
C-enhancement Category Enhancements help wanted Extra attention is needed

Comments

@waynexia
Copy link
Member

What type of enhancement is this?

Tech debt reduction

What does the enhancement do?

This interface inherits common_query::Output from the previous table engine.

pub enum Output {
    AffectedRows(usize),
    RecordBatches(RecordBatches),
    Stream(SendableRecordBatchStream),
}

It combines the result of query (RecordBatches and Stream) and non-query (AffectedRows) together. After refactoring to region engine and region server, those requests are handled separately in two APIs. RegionEngine::handle_request() only handles non-query requests, thus the return type can be simplified to only contains the AffectedRows branch.

Implementation challenges

No response

@waynexia waynexia added C-enhancement Category Enhancements help wanted Extra attention is needed Size: M labels Nov 21, 2023
@Dysprosium0626
Copy link
Contributor

Can I have a try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants